Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove lookup v1 #207

Merged
merged 8 commits into from
Apr 27, 2023
Merged

chore: remove lookup v1 #207

merged 8 commits into from
Apr 27, 2023

Conversation

fuchsnj
Copy link
Member

@fuchsnj fuchsnj commented Apr 27, 2023

The removes all remaining traces of the deprecated "lookup v1" code. Full migration to V2 has been completed.

The v2 code structure will modified in the future to remove "v2" from the name. I'm leaving it out for now so it's easier to upgrade without potential naming confusion.

Copy link
Collaborator

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, but I have a history of missing thing when it comes to the lookup code - so definitely worth a second review.

lib/compiler/src/expression/assignment.rs Show resolved Hide resolved
@fuchsnj fuchsnj merged commit e723f96 into main Apr 27, 2023
@fuchsnj fuchsnj deleted the fuchsnj/lookup_cleanup branch April 27, 2023 16:18
itkovian pushed a commit to itkovian/vrl that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants