Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added supported null \0 escape character to new lexer #219

Closed
wants to merge 0 commits into from

Conversation

arthmoeros
Copy link
Contributor

@arthmoeros arthmoeros commented May 4, 2023

Ref #148

added supported null \0 escape character to new lexer

Copy link
Contributor

@StephenWakely StephenWakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Could you please add a test to cover this. You should be able to do something very similar to this https://github.com/vectordotdev/vrl/blob/main/lib/parser/src/lex.rs#L1481-L1499

Let me know if you have any questions about the way that test is set up..

@fuchsnj
Copy link
Member

fuchsnj commented May 23, 2023

@arthmoeros Is this something you are planning on continuing, or do you need some assistance?

@arthmoeros
Copy link
Contributor Author

Hi @fuchsnj , I did miss @StephenWakely response, I'm sorry!

I was checking out the provided link, but I think it is broken (404). I was trying to find where to add a test for this, but I'm having trouble finding it.

@fuchsnj
Copy link
Member

fuchsnj commented May 25, 2023

I was checking out the provided link, but I think it is broken (404). I was trying to find where to add a test for this, but I'm having trouble finding it.

There was some significant refactoring recently that moved a lot of files. The new link is:
https://github.com/vectordotdev/vrl/blob/main/src/parser/lex.rs#L1481-L1499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants