Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlib): introduce CTR-LE and CTR-BE encryption/decryption #299

Merged
merged 5 commits into from
Jul 10, 2023

Conversation

alisa101rs
Copy link
Contributor

Fixes #298

I am not sure how to mark "AES--CTR" as deprecated, but this PR introduces "AES--CTR-LE" and "AES--CTR-BE" encryption/decryption. "AES--CTR" is treated as "AES-*-CTR-LE".

@dsmith3197 dsmith3197 added vrl: stdlib Changes to the standard library type: feature A value-adding code addition that introduce new functionality. labels Jul 6, 2023
@jszwedko jszwedko requested a review from a team July 6, 2023 13:53
@pront
Copy link
Collaborator

pront commented Jul 6, 2023

Thank you for this PR! We can take care of the deprecation, created #301.

@pront
Copy link
Collaborator

pront commented Jul 7, 2023

LGTM! Can you please add a section in CHANGELOG.md listing the new encryption options?

I would also like to get a stamp from @fuchsnj before merging.

Copy link
Member

@fuchsnj fuchsnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a changelog entry. Thanks!

@pront pront merged commit 2f083c4 into vectordotdev:main Jul 10, 2023
8 checks passed
@ffcactus
Copy link

Hello @fuchsnj may I know which Vector's version would include this fix? When will that version release?

@pront
Copy link
Collaborator

pront commented Jul 17, 2023

Hello @fuchsnj may I know which Vector's version would include this fix? When will that version release?

This will be included in the next VRL release v0.6.0 and probably Vector v0.32.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A value-adding code addition that introduce new functionality. vrl: stdlib Changes to the standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support both Big and Little Endian for AES-*-CTR encryption modes
6 participants