[Issue LangStream#741] Add fsGroup for runtime pod (LangStream#743)

vectorize-io · Dec 11, 2023 · c80f4a9 · c80f4a9
1 parent fca9e79
commit c80f4a9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/...-k8s-deployer-core/src/main/java/ai/langstream/deployer/k8s/apps/AppResourcesFactory.java b/...-k8s-deployer-core/src/main/java/ai/langstream/deployer/k8s/apps/AppResourcesFactory.java
@@ -32,18 +32,7 @@
 import ai.langstream.runtime.api.application.ApplicationSetupConstants;
 import ai.langstream.runtime.api.deployer.RuntimeDeployerConfiguration;
 import ai.langstream.runtime.api.deployer.RuntimeDeployerConstants;
-import io.fabric8.kubernetes.api.model.Container;
-import io.fabric8.kubernetes.api.model.ContainerBuilder;
-import io.fabric8.kubernetes.api.model.EmptyDirVolumeSource;
-import io.fabric8.kubernetes.api.model.EnvVar;
-import io.fabric8.kubernetes.api.model.EnvVarBuilder;
-import io.fabric8.kubernetes.api.model.KeyToPathBuilder;
-import io.fabric8.kubernetes.api.model.Pod;
-import io.fabric8.kubernetes.api.model.Quantity;
-import io.fabric8.kubernetes.api.model.Volume;
-import io.fabric8.kubernetes.api.model.VolumeBuilder;
-import io.fabric8.kubernetes.api.model.VolumeMount;
-import io.fabric8.kubernetes.api.model.VolumeMountBuilder;
+import io.fabric8.kubernetes.api.model.*;
 import io.fabric8.kubernetes.api.model.batch.v1.Job;
 import io.fabric8.kubernetes.api.model.batch.v1.JobBuilder;
 import io.fabric8.kubernetes.client.KubernetesClient;
@@ -393,6 +382,7 @@ private static Job generateJob(
                 .withLabels(labels)
                 .endMetadata()
                 .withNewSpec()
+                .withSecurityContext(getPodSecurityContext())
                 .withTolerations(podTemplate != null ? podTemplate.tolerations() : null)
                 .withNodeSelector(podTemplate != null ? podTemplate.nodeSelector() : null)
                 .withServiceAccountName(serviceAccountName)
@@ -466,6 +456,10 @@ private static Map<String, String> getPodAnnotations(PodTemplate podTemplate) {
         return annotations;
     }
 
+    private static PodSecurityContext getPodSecurityContext() {
+        return new PodSecurityContextBuilder().withFsGroup(10_000L).build();
+    }
+
     public static Map<String, String> getLabelsForDeployer(boolean delete, String applicationId) {
         return Map.of(
                 CRDConstants.COMMON_LABEL_APP,

diff --git a/...-deployer-core/src/test/java/ai/langstream/deployer/k8s/apps/AppResourcesFactoryTest.java b/...-deployer-core/src/test/java/ai/langstream/deployer/k8s/apps/AppResourcesFactoryTest.java
@@ -127,6 +127,8 @@ void testDeployerJob() {
                                 - mountPath: /cluster-runtime-config
                                   name: cluster-runtime-config
                               restartPolicy: Never
+                              securityContext:
+                                fsGroup: 10000
                               serviceAccountName: my-tenant
                               volumes:
                               - emptyDir: {}
@@ -226,6 +228,8 @@ void testDeployerJob() {
                                 - mountPath: /cluster-runtime-config
                                   name: cluster-runtime-config
                               restartPolicy: Never
+                              securityContext:
+                                fsGroup: 10000
                               serviceAccountName: my-tenant
                               volumes:
                               - emptyDir: {}
@@ -342,6 +346,8 @@ void testSetupJob() {
                                 - mountPath: /cluster-runtime-config
                                   name: cluster-runtime-config
                               restartPolicy: Never
+                              securityContext:
+                                fsGroup: 10000
                               serviceAccountName: runtime-my-tenant
                               volumes:
                               - emptyDir: {}
@@ -438,6 +444,8 @@ void testSetupJob() {
                                 - mountPath: /cluster-runtime-config
                                   name: cluster-runtime-config
                               restartPolicy: Never
+                              securityContext:
+                                fsGroup: 10000
                               serviceAccountName: runtime-my-tenant
                               volumes:
                               - emptyDir: {}