Sign rpk for macOS on release #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When making a release, for the macOS binary use gon to sign the package and get it notarized.
rkruze
requested review from
0x5d,
dotnwat,
mmaslankaprv and
emaxerrno
as code owners
|
|
|
In order for this to run properly, a few secrets will have to be set. I have passed these onto @senior7515 |
|
done. |
0xdiba
approved these changes
Nov 23, 2020
0x5d
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a release, for the macOS binary use gon to sign the package
and get it notarized.
Checklist
When referencing a related issue, remember to migrate duplicate stories from the
external tracker. This is not relevant for most users.