Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms and Conditions Page remains permanently saving #92

Closed
cuatrocento opened this issue May 11, 2018 · 16 comments
Closed

Terms and Conditions Page remains permanently saving #92

cuatrocento opened this issue May 11, 2018 · 16 comments
Labels

Comments

@cuatrocento
Copy link

When we try to enable Terms and Conditions on every Contribution Page

@cuatrocento cuatrocento changed the title Terms and Conditions Page remains permanently updating Terms and Conditions Page remains permanently saving May 11, 2018
@veda-consulting
Copy link
Member

@cuatrocento could you clarify what the issue is?

@cuatrocento
Copy link
Author

Yesterday, I could not save Terms & Conditions sections on a contribution page, but now I can.
The problem now is that I do not see the Terms & Conditions section on the contributions front page after saving it. I have tried changing the position of the checkbox. There are no visible errors.

Thanks for your answer. Sorry for my English.

@veda-consulting
Copy link
Member

@cuatrocento ok could you confirm the version of CiviCRM, CMS and the GDPR extension? Thanks

@cuatrocento
Copy link
Author

GDPR 2.5
CiviCrRM 4.7.4
Drupal 7.55

Thks

@AlphaDE
Copy link

AlphaDE commented Jun 7, 2018

I have a similar problem on CiviCRM 5.2.0. After activating the module on an event registration page and after confirming both Privacy and T&C agreements, confirming all settings throws me back to the registration page with

Please correct the following errors in the form below

  • Terms & Conditions is a mandatory field.
  • Terms & Conditions is a mandatory field.

and I cannot proceed. With that, the GDPR module is yet unuseable for me.

PHP Version: | 7.1.13
WordPress Version: | 4.9.6
Server Software: | Apache/2.4.33 (Debian)

@AlphaDE
Copy link

AlphaDE commented Dec 22, 2018

Problem is persisting with latest Wordpress, CiviCRM and GDPR versions.

It's is strange that nothing happened for 6 months on this matter.

@cuatrocento
Copy link
Author

Yes, I opted to stop using it due to the lack of solutions.

@AlphaDE
Copy link

AlphaDE commented Dec 22, 2018

Same here, I created mandatory fields in event registrations... a pity that they do not even care...

@veda-consulting
Copy link
Member

@AlphaDE I don't think it's fair to say we do not care. We are supporting this module without investment and are hoping members of the community step up to fix at least some of the on going issues.

We will take a look at the problem over the coming days.

@deepak-srivastava
Copy link
Collaborator

@AlphaDE @cuatrocento we couldn't reproduce the problem on latest civicrm (5.8.2), wordpress 5.0.2 and gdpr 2.7.

If you guys can ping me on civicrm chat - i can try investigate the problem on your setup.
My username "deepaks".

@AlphaDE
Copy link

AlphaDE commented Dec 24, 2018

I wrote you a PM there...

@deepak-srivastava
Copy link
Collaborator

UPDATE:
@AlphaDE allowed me have a look at their site. And it seems that for frontend pages (on wordpress) due to theme or js failures, 'terms and conditions' block is outside the form, which is causing values to not submit. Screenshot :
image
@AlphaDE is about to look into their customization or setup civi in a way (possible a subdomain) that customization doesn't affect it, and report back.

@AlphaDE
Copy link

AlphaDE commented Dec 25, 2018

Good morning @deepak-srivastava
I just started to have a closer look... the jQuery errors you noticed were caused by the CiviCRM mobile plugin adding it's initializing code just before everything, consequently also before

addLoadEvent = function(func){if(typeof jQuery!="undefined")jQuery(document).ready(func);else if(typeof wpOnload!='function'){wpOnload=func;}else{var oldonload=wpOnload;wpOnload=function(){oldonload();func();}}};

So the registration pages loads without script errors, nevertheless, the effect remains the same, the acknowlegement of T&C is not taken to the next page when registering for an event.

But the GDPR T&C form is still outside the form

and that's a question of the generation of the registration page. This happens for both "bottom" "Checkbox position" in the event configuration. With the top ones, it goes up and works.

@deepak-srivastava
Copy link
Collaborator

UPDATE:
Checked with @AlphaDE again. Seems like its working when logged in but not when logged out (frontend pages). It seems like wordpress frontend pages are stripping out civicrm js.
Following screenshot shows the js files / resources that are missing for frontend pages, which is causing javscript to not work:
image

@AlphaDE
Copy link

AlphaDE commented Dec 27, 2018

With some extensive debug sessions we tracked down the problem and found a reason at least on my installation.
@deepak-srivastava found that any CiviCRM specific scripts were not loaded when using the registration page while not being logged in.
I am using the WP plugin "EU Cookie Law" which was configured to block any scripts (Auto Block option) until the user agreed to use them. That caused the plugin to do what it was told to do... stripping the scripts.
Confirming the popup and reloading the page got it working...

To avoid "normal users" run into that problem, I switched Auto Block off for the time being as I do not use any "spying" scripts anyway.

Thanks @deepak-srivastava for taking time!

@deepak-srivastava
Copy link
Collaborator

Cool that you figured it out and good to know. Might help others as well. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants