-
Notifications
You must be signed in to change notification settings - Fork 74
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text does not align #237
Comments
Same issue here Drupal 7, Civi 4.7.30, Mosaico Beta 3 |
We've encounted the same issue - Mosaico Beta 2 - as a temporary work around it looks like you can use a div instead of a paragraph and the text alignment works as expected. Formats-> Blocks -> Div. |
Same issue here WordPress 5.2.1, CiviCRM 5.13.4 and Mosaico 2.0 stable. Everything looks and saves fine within Mosacio when text is centred, but HTML preview or opening in Gmail it appears left aligned. Managed to work around with @stesi561 suggestion - thanks very much! |
Still issue with 2.1. |
We found the same issue. The solution from @stesi561 works. Agileware ref: CIVIMOSAIC-24 |
I can confirm that the PR voidlabs/mosaico@ed38839 is fixing this. (applied on packages/mosaico/dist/mosaico.min.js.map for a quick fix). |
@samuelsov Can you guide me how to edit that file in order to implement fix? I've been struggling with align not working for some time and got 0 response for solving it, hopefully you can help me replicate this fix. Thanks in advance |
@Shwele a quick workaround - select the text you want to align, put it in a div, then align it - it should work. |
I just ran into this as well. Is there a plan for implementing new releases of the Mosaico library? There are some other fixes/improvements upstream that would be great to have implemented. |
@lcdservices The only way to get this to work is to put the text in a div before choosing an alignment. It is stupid but that's what we have to do. |
@themak1985 it's fixed upstream in the Mosaico library. The current Civi extension is running an older version of that library. Thus my question about whether there are plans to upgrade at some point. |
Does anyone know of potential issues with updating Mosaico? I opened a PR on our fork. |
I did the following test:
then copied over the Center align was fixed. Most things seem to work, except:
|
Not fixed:
I have no idea what I'm doing, so any tips welcome. To fix the logo:
|
@mlutfy Upgrading should be pretty straightforward. I did it a couple of years ago but then abandoned it. Basically you need to merge upstream into master and then look through this list voidlabs/mosaico@master...civicrm:v0.15-civicrm-2 and work out which need to be re-applied / refactored. Given that mosaico doesn't seem well maintained at the moment it would also be a good idea to go down the list of pull requests at voidlabs and merge some in (eg. translation ones). I keep thinking about trying to do a MIH to get this all updated but have not had the time as yet. |
We're actually working upgrading for NYSS, so may have some PRs for review shortly. Would love to have others jump in and help with testing. |
Sounds good! I would be happy to test. From Matt's instructions, I see that we need to PR against the v0.15-civicrm-2 branch, so my tests would have broken tokens, test mails, and a few other things :) |
Attached find a diff that applies the centered text fix mentioned above to Civi Mosaico 2.6. |
@lcdservices are you able to share your progress on this? Happy to help test or continue any in-progress work. |
What works for me to center or justify text is in html code to replace |
@mattwire You closed this but this bug is still present in Mosaico 2.8. Looking at |
We need a Make It Happen or similar to upgrade the version of Mosaico we ship from 0.15 to 0.17 (latest) |
There is a PR here: civicrm/mosaico#9 |
Attached is a .zip file of Mosaico 2.8 with this alignment issue fixed. Please use emoji reactions to indicate if it works for you. |
Here is Mosaico 2.9 with this alignment issue fixed: uk.co.vedaconsulting.mosaico-2.9-leftalignfix.zip |
Mosaico 2.10: uk.co.vedaconsulting.mosaico-2.10-leftalignfix.zip |
Thanks @MegaphoneJon. Just yesterday was applying your patch on Mosaico 2.10. Does anyone know how far we are from being able to update to a more current version of Mosaico? |
Text alignment does not work: although it is possible to change text alignment to center, justify, or right and tags look correct, alignment is reset to left (1) in HTML preview, and (2)when email is sent.
The text was updated successfully, but these errors were encountered: