Add keyboard navigation minor mode #39
Conversation
Introduces standard-Emacs-like concepts of point, mark, region, and cursor into pdf-tools and uses these to implement keyboard-based navigation, selection, and annotation in pdf files.
Use pdf-view-midnight-colors as cursor rather than pdf-keynav-cursor
This adds the commands 'pdf-keynav-annot-add-text-left/right' and a variable 'pdf-keynav-annot-text-margin' to control where the text annotations are placed in the margins. A function 'pdf-keynav-annot-delete-closest-text' is also added and command 'pdf-keynav-annot-delete' is modified to incorporate it. Furthermore, an error in 'pdf-keynav-annot-activate' has been fixed, plus custom types have been adjusted and various formatting fixed.
- Remove some unused variables - string-reverse is obsolete, use reverse - use let instead of assigning to free variables
|
This is brilliant and really well-thought out! It is of course annoying that navigation (especially character-by-character with I did some cleanup of the code here: orgtre#2 |
|
Thanks! I merged the cleanup. The only way I can come up with to make it faster is to co-opt the mouse pointer as cursor. This has some obvious drawbacks as that's not what the mouse pointer is for and I've not managed to work the positioning out properly yet, but a proof-of-concept is in the "pointer-as-cursor" branch. Any other ideas are welcome. |
Fix disabling of pdf-keynav-mode when pdf-sync is not loaded
|
This is great @orgtre! This particular feature has been on my todo list for a while. Sorry for ignoring the PR for a bit, but I plan to review the code and test it out over the weekend. I'll get back with thoughts and feedback (if any) in the next week. |
vedang
added
the
new feature implementation
Hide don't hide mouse pointer when `df-keynav-display-pointer-as-cursor`.
Add options to fine-tune positioning of pointer.
With it, when `pdf-keynav-display-pointer-as-cursor` is set, point is always simply where the mouse pointer is. This might be less confusing.
Add options to control the pointer shape in this mode.
|
I am picking up the review of this giant set of changes this week, looking forward to finally testing it out. Where possible, I will squash / update the commits myself instead of getting back with review comments -- because this is such a big change across so many commits. I'll get back here with questions / doubts, if any. Thank you! |
|
Wow great! Feel free to do what you want. Let me know if there is anything I can do. Thanks for your work (the last 8 hours were huge for pdf tools)! |
|
Has there been any progress on this? |
|
No, unfortunately I have not been able to make the time.
This is a really big change and needs some careful focus. I have a week set
aside in May (8th to 12th May) where I am on vacation from my day job and
have time to work on pdf-tools. This is the first PR I plan to work on in
that time.
…On Sat, Apr 15, 2023 at 8:38 PM asymmetric ***@***.***> wrote:
Has there been any progress on this?
—
Reply to this email directly, view it on GitHub
<#39 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAUUHWWE2WP4XVE6VNWDWDXBK2WVANCNFSM5CJWMHDA>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Cheers,
Vedang
https://vedang.me
@vedang on Twitter
|
Introduces standard-Emacs-like concepts of point, mark, region, and cursor into
pdf-tools and uses these to implement keyboard-based navigation, selection, and
annotation in pdf files.