Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Idea]: Ability to update RelativeFilePath #99

Closed
sitiom opened this issue Feb 13, 2023 · 3 comments
Closed

[Feature/Idea]: Ability to update RelativeFilePath #99

sitiom opened this issue Feb 13, 2023 · 3 comments
Labels
feat New feature request

Comments

@sitiom
Copy link
Contributor

sitiom commented Feb 13, 2023

What would you like to see changed/added?

Related to #82 (comment), russellbanks/Komac#90

Support for 1.4 manifests. Also, updating the RelativeFilePath should be supported in cases where the executable is inside a versioned directory. For example:

- RelativeFilePath: bat-v0.22.1-x86_64-pc-windows-msvc\bat.exe

I don't see an input that does this, so I'm assuming this hasn't been added yet.

@sitiom sitiom added the feat New feature request label Feb 13, 2023
@vedantmgoyal9
Copy link
Owner

vedantmgoyal9 commented Feb 13, 2023

I don't think a separate input is needed for this. You have already created an issue on Komac's repo, @russellbanks will add the feature. A simple regex replace can be done for it, where select previous match in the string, and replace it with the new version.

I'll keep the issue open until it's resolved in Komac.

@sitiom

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature request
Projects
None yet
Development

No branches or pull requests

2 participants