Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinGet-based installation #1102

Closed
zkat opened this issue Jul 7, 2020 · 15 comments · Fixed by #2519
Closed

WinGet-based installation #1102

zkat opened this issue Jul 7, 2020 · 15 comments · Fixed by #2519
Labels
help wanted Extra attention is needed packaging/tooling windows Issue is related to the Windows build of bat

Comments

@zkat
Copy link

zkat commented Jul 7, 2020

It would be really great to be able to install bat on Windows through the windows package manager, winget.

@zkat zkat added the feature-request New feature or request label Jul 7, 2020
@sharkdp
Copy link
Owner

sharkdp commented Jul 25, 2020

Thank you very much for the feedback. Is there anything that we can do here or would it be best to open a ticket on the upstream issue tracker?

@sharkdp sharkdp added packaging/tooling help wanted Extra attention is needed windows Issue is related to the Windows build of bat and removed feature-request New feature or request labels Jul 25, 2020
@zkat
Copy link
Author

zkat commented Aug 5, 2020

I think the main thing to do on your end is to set up a wix-based installer that can then be upstreamed.

@sharkdp
Copy link
Owner

sharkdp commented Aug 15, 2020

We don't have any packaging-related code here in the repo (except for the automatic build of Debian packages). I also don't want to (and don't feel able to) maintain packages for systems that I don't personally use.

Is cargo-wix a requisite to have bat packaged in winget? Or just a convenient way to create winget packages?

@sharkdp
Copy link
Owner

sharkdp commented Oct 16, 2020

I'm going to close this, as I don't really see any value in tracking this here. Let me know if someone thinks otherwise.

@sharkdp sharkdp closed this as completed Oct 16, 2020
@sitiom
Copy link
Contributor

sitiom commented Jan 26, 2023

@sharkdp The latest release of Winget now supports zip installation (https://github.com/microsoft/winget-cli/releases/tag/v1.4.10173). There is an ongoing PR for it:

You only need to set up the Winget Releaser workflow when it is merged. Are you willing to accept a PR to add Winget Releaser in this repo (and possibly the other ones)?

@sharkdp
Copy link
Owner

sharkdp commented Jan 29, 2023

Thank you. I really don't want to maintain any package management stuff inside this repository (except for what we have already with the Debian packages). Of course it would be great if bat could be installed via winget, but is a PUSH based approach really necessary? Can't winget package maintainers PULL the information from the bat repo? (just like everyone else)

@sharkdp sharkdp reopened this Jan 29, 2023
@sharkdp
Copy link
Owner

sharkdp commented Jan 29, 2023

If that's really the only way, I'm open to adding this workflow. Worst case, we can just delete it in case it creates problems and no one is here to fix them.

@sitiom
Copy link
Contributor

sitiom commented Jan 29, 2023

Can't winget package maintainers PULL the information from the bat repo? (just like everyone else)

The problem is that only one maintainer is doing the pulling for most packages, and it is taking a toll on the CI (winget-pkgs-automation, same author as the Winget Releaser). Winget Releaser was created so that GitHub authors can take the pushing by themselves and help ease the CI for other packages on the automation.

Worst case, we can just delete it in case it creates problems and no one is here to fix them.

I can help as long as I use this software.

@sharkdp
Copy link
Owner

sharkdp commented Feb 1, 2023

Ok. Let's do it.

@sitiom
Copy link
Contributor

sitiom commented Feb 2, 2023

On the Winget Releaser side, vedantmgoyal9/winget-releaser#99 would have to be solved first.

@mrBen mrBen mentioned this issue Feb 10, 2023
@kritr-msft
Copy link

Seems like the issue is resolved! @sitiom are you planning on taking a stab at this ?

@sitiom
Copy link
Contributor

sitiom commented Mar 22, 2023

As you can see, bat is not yet merged into Winget due to a blocking issue with dependencies (VCRedist), despite hyperfine and fd being merged, which have the same dependencies.

@sitiom
Copy link
Contributor

sitiom commented Mar 28, 2023

PR now merged: microsoft/winget-pkgs#100636. Here is the Winget Releaser PR:

@cprivitere
Copy link

Should probably add it to the readme as an install option. Worked for me today!

@sitiom
Copy link
Contributor

sitiom commented May 11, 2023

Should probably add it to the readme as an install option. Worked for me today!

Already covered in the mentioned PR above. @sharkdp just has to review and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed packaging/tooling windows Issue is related to the Windows build of bat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants