Remove stray auto-generated config files #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are also generated by vesc_tool.
Updates the example to use the vesc_tool CLI to generate the config files. In addition to being much cleaner, it inherently gives the "recipe" to get the right files, instead of requiring the user to know how to generate them using the GUI tool.
|
What's your handle on discord? how can we talk to you? Plenty of users are struggling to build packages... |
|
riddimrider1 on discord. You didn't reply last time I messaged you there 😇 |
|
Geez, this is what I hate about Discord - people use random-ass names so you have no idea whom you're talking to... Well, I'll try my best to remember now. Also, for people who contribute to github it would be really nice if you could just change your name to match or at least be similar to your github name |
|
The discussion on discord died, I've summed up the results so far in #33. This PR is unrelated to the issue, can we proceed with review and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies, when making #21 I forgot two auto-generated files in git.
That is besides
confparser.hwhich I'm still keeping forbalanceandfloat, but I also added a commit to update theconfigexample, and there I remove that one as well, as I think it's the correct approach.(I also didn't touch the new
tntpackage, as @Izzygit isn't using the config auto-generation there)