-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribute through flatpak #112
Comments
Build is ready on flathub, you can try with:
a first benefit is that tool honors theme, here dark version used on my system: @vedderb Let me know if you approve this, so we can merge the app in flathub. |
Not going via the vesc-project site misses an opportunity to give a donation, which is where 95% of the donations come from. That being said, people using a free OS is something I want to support, so it is nice to give them some advantages in the form of an easy flatpak install :-) The one thing that worries me is that the built-in firmwares might be the wrong version if the build is pulled between when I update vesc tool and when I push the firmwares resource files. Is there some way for me to trigger which commit should be used for the next build, so that the built-in firmwares always are in sync correctly? |
Absolutely. You can bind to a tag, commit or build from tar if you prefer. There're some work about paid apps on flatpak and site will link the donations in its metadata. Just tell me where 2.06 version commit is and as soon as you release 2.07 or 3.00 we can launch a new version. |
I found this possible commits for versions (looking at VT_VERSION
But looking in detail:
release could be made on last commits with same VT_VERSION. Just let me know to release v2.06. For v2.07 or v3.00 I'm not sure as they are not available on your site. Would be great if you tag commits for that. |
The plan with the master branch is that the latest commit always is stable, and that development is done on development branches that then are merged to master when they are ready. Sometimes new firmwares are added to master, but that does not change the version, it only updates the included firmwares. The only time the latest commit is not stable is the moment when I'm working on merging a development branch to master once it is tested and ready. This is only the case for an hour or so every two months or so, but it is good to be aware of that. It should be safe to assume that if the latest commit in the master branch is more than two days old, it is the latest stable release. The version number can be found in in vesc_tool.pro. |
You have a workflow that works, just in case it helps, probably open a branch 2 where you can cherry pick changes will allow to create 2.07, 2.08, 2.09... etc. Master can be on version 3, until you decide on a big change (version 4) where you create branch 3 and start to create tag 3.00, 3.01... this way you can even apply this fixes (like the problem with enums) in a 2.06.1 or similar (not always backport changes is possible) So should I go with f992d39 as 2.06? Probably I will apply the enum fix on top of that so you can see what I mean. |
Your fix is already in master, it was the last thing that made it for this release. You can go with b0632c4 and version 3.00. Next version will be 3.01, which will move to master when I feel that it is ready and tested. At the moment I don't see any need for supporting old releases, as the new ones work with old firmwares too. |
Cool. Then from flatpak side everything is done: Commit for version 3.00: Link to donations: I asked about how to connect the flatpak app with your current donation methods. Not really sure but probably that will need some kind of Rest API on your site (totally guessing at this time). Just ask that on last comment here: flathub/flathub#2043 (comment) |
spreading on social media: https://twitter.com/albfanjul/status/1349839463942397959 Seems after build different flatpak versions for a release (Platinum, Gold, Silver, Bronze, Free) they can be linked somehow to your website. |
Nice, thanks for setting this up! I gave it a quick try (my first time using flatpak), and noticed that the map in log analysis does not work. It does not seem to be able to download the openstreetmap tiles. Is there perhaps some missing permission in the flatpak build? Also, will vesc tool show up on the flathub website or is there any extra action needed from me? |
I just check an upload hardware firmware with flatpak app (3.00). Then I setup motor and input with it too. All work correctly. If you want to distribute flatpakrefs on website I guess you will get all the goals. I cannot make anyone to explain me how paid apps should work on flatpak. I guess do something and wait for "someone is wrong in internet" would probably be the faster way to understand how it should work |
Done: https://flathub.org/apps/details/com.vesc_project.VescTool Any mailing list or RSS to notify new versions? I will maintain the flatpak app. |
In case of any issue with flatpak use https://github.com/flathub/com.vesc_project.VescTool/issues |
To ease distribution on *nix environments I have created flathub/flathub#2043 so VESC tool can be distributed through flatpak.
Let me know if you're interested on that kind of release to polish icon, metadata and do final submit.
flathub allows beta version if you need feedback for unrelease code.
I'm not sure about the options to release Platinum, Gold, Silver, Bronze through an app store that allows payments: More info here
flathub/flathub#680
The text was updated successfully, but these errors were encountered: