Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add com.github.VescTool #2043

Closed
wants to merge 1 commit into from
Closed

add com.github.VescTool #2043

wants to merge 1 commit into from

Conversation

albfan
Copy link

@albfan albfan commented Jan 11, 2021

Tool to program VESC hardware

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

@albfan
Copy link
Author

albfan commented Jan 11, 2021

The app miss the final cleanups until I check with current maintainers (@vedderb) if they are interested in this kind of distribution

This was referenced Jan 11, 2021
@albfan
Copy link
Author

albfan commented Jan 11, 2021

bot, build com.github.VescTool

@flathubbot
Copy link

Queued test build for com.github.VescTool.

@flathubbot
Copy link

Started test build 36496

@flathubbot
Copy link

Build 36496 failed

com.github.VescTool.yaml Outdated Show resolved Hide resolved
@albfan
Copy link
Author

albfan commented Jan 11, 2021

bot, build com.github.VescTool

@flathubbot
Copy link

Queued test build for com.github.VescTool.

@flathubbot
Copy link

Started test build 36511

@flathubbot
Copy link

Build 36511 failed

@albfan
Copy link
Author

albfan commented Jan 13, 2021

bot, build com.github.VescTool

@flathubbot
Copy link

Queued test build for com.github.VescTool.

@flathubbot
Copy link

Started test build 36635

@flathubbot
Copy link

Build 36635 failed

@albfan
Copy link
Author

albfan commented Jan 13, 2021

bot, build com.github.VescTool

@flathubbot
Copy link

Queued test build for com.github.VescTool.

@flathubbot
Copy link

Started test build 36636

@flathubbot
Copy link

Build 36636 failed

@albfan
Copy link
Author

albfan commented Jan 13, 2021

bot, build com.github.VescTool

@flathubbot
Copy link

Queued test build for com.github.VescTool.

@flathubbot
Copy link

Started test build 36638

@flathubbot
Copy link

Build 36638 failed

@flathubbot
Copy link

Build 36741 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/35368/com.github.VescTool.flatpakref

@albfan
Copy link
Author

albfan commented Jan 14, 2021

@Erick555, Maintainer agrees to create this app on version 3.00. Would be great to have it published to tweet about it and try to find a solution to its donation workflow, which is based on buy same app with a different badge and special permissions on their website. (not sure how to address that but could be an interesting use case for other open source projects. Maybe @alexlarsson has an idea on how to implement that. See their options right now https://vesc-project.com/donations

@Erick555
Copy link

That's great but I'm not flathub admin so I can't help you any further with publishing this. If you need anything ask @barthalion or someone else.

com.github.VescTool.yaml Outdated Show resolved Hide resolved
com.github.VescTool.yaml Outdated Show resolved Hide resolved
@albfan
Copy link
Author

albfan commented Jan 15, 2021

bot, build com.vesc_project.VescTool

@flathubbot
Copy link

Queued test build for com.vesc_project.VescTool.

@flathubbot
Copy link

Started test build 36753

@flathubbot
Copy link

Build 36753 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/35381/com.vesc_project.VescTool.flatpakref

@albfan
Copy link
Author

albfan commented Jan 15, 2021

bot, build com.vesc_project.VescTool

@flathubbot
Copy link

Queued test build for com.vesc_project.VescTool.

@flathubbot
Copy link

Started test build 36794

@flathubbot
Copy link

Build 36794 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/35422/com.vesc_project.VescTool.flatpakref

@albfan
Copy link
Author

albfan commented Jan 16, 2021

I just check an upload hardware firmware with flatpak app. Then I setup motor and input with it too. All work correctly.

Added --device=all to access hardware

bot, build com.vesc_project.VescTool

@flathubbot
Copy link

Queued test build for com.vesc_project.VescTool.

@flathubbot
Copy link

Started test build 36893

@flathubbot
Copy link

Build 36893 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/35517/com.vesc_project.VescTool.flatpakref

@nedrichards nedrichards changed the title VESC tool add com.github.VescTool Jan 24, 2021
@nedrichards
Copy link
Member

@albfan are you still waiting for those final cleanups?

@albfan
Copy link
Author

albfan commented Jan 26, 2021

@nedrichards from our perspective this is ready. App fully works. upstream maintainers would love to be able to distribute different versions from flatpak, but that's another story. I suppose the should distribute the flatpakref, right?

This is ready to merge.

@nedrichards
Copy link
Member

/merge

1 similar comment
@barthalion
Copy link
Member

/merge

@barthalion
Copy link
Member

Sorry, I will look into this failure tomorrowish.

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this has been created: https://github.com/flathub/com.vesc_project.VescTool

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants