Adding 2bpp to Import and Export in Font Editor #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
r3n33
commented
Mar 12, 2024
| @@ -404,10 +439,22 @@ void PageDisplayTool::on_fontEditImportButton_clicked() | |||
| QImage img(w * charNum, h, QImage::Format_ARGB32); | |||
| img.fill(Qt::black); | |||
|
|
|||
| //TODO: How do I get these colors from the pallet below the view? | |||
There was a problem hiding this comment.
I am curious if I can grab the pallet colors from the display editor at this point? I spent an embarrassing amount of time trying to figure it out and I'm not sure if we want to use the pallet colors in case the user is in indexed 2 or 16 format. Advice would be much appreciated!
There was a problem hiding this comment.
Nice work on the antialiasing!
If you think it helps to grab and use the palette-colors here I can add some functions to enable that. I just pushed some code that updates the palette when activating anti-aliasing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.