Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the notification begging box #88

Closed
runxel opened this issue Jan 16, 2020 · 3 comments
Closed

Get rid of the notification begging box #88

runxel opened this issue Jan 16, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@runxel
Copy link

runxel commented Jan 16, 2020

Describe the change you'd like:
Hey there!
First things first: I totally love this dark mode of yours, especially great with the theme switcher.

However I'd like to make a valuable addition and get rid of the notification-enable-begging message box. It's totally superfluous (no, I don't want to have any desktop notifications) and takes away so much of the screen estate.
Of course this needs it's own setting.

If you agree I'd make a PR ready :)
(Basically just another switch + display: none; rule)

@runxel runxel added the enhancement New feature or request label Jan 16, 2020
@erelado
Copy link
Collaborator

erelado commented Jan 16, 2020

Interesting suggestion.
Might be smart to make a new configuration option of "Show head notifications" and include 3 options:

  1. Show
  2. Hide browser's notification
  3. Hide

@runxel
Copy link
Author

runxel commented Jan 16, 2020

2\. Hide browser's notification

Firefox startet to not show the notification, that there are notifications available (🤦‍♂) anyway... Or do I miss what you meant?

@vednoc
Copy link
Owner

vednoc commented Jan 16, 2020

This would be a great addition!

My thinking is very similar to @E-RELevant's suggestion. We could have it hide alerts altogether, or have it hide only the 'toggle notification' alert. The code for that can be added here.

As a reference, here is how we remove all alerts in compact mode.

erelado added a commit to erelado/dark-whatsapp that referenced this issue Jan 19, 2020
Choose between 3 different states:
1. Show all alerts
2. Hide "Turn on desktop notifications" alert
3. Hide all alerts

fixes issue vednoc#88.
@vednoc vednoc closed this as completed in b705b8e Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants