New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of the notification begging box #88
Comments
Interesting suggestion.
|
Firefox startet to not show the notification, that there are notifications available (🤦♂) anyway... Or do I miss what you meant? |
This would be a great addition! My thinking is very similar to @E-RELevant's suggestion. We could have it hide alerts altogether, or have it hide only the 'toggle notification' alert. The code for that can be added here. As a reference, here is how we remove all alerts in compact mode. |
Choose between 3 different states: 1. Show all alerts 2. Hide "Turn on desktop notifications" alert 3. Hide all alerts fixes issue vednoc#88.
Describe the change you'd like:
Hey there!
First things first: I totally love this dark mode of yours, especially great with the theme switcher.
However I'd like to make a valuable addition and get rid of the notification-enable-begging message box. It's totally superfluous (no, I don't want to have any desktop notifications) and takes away so much of the screen estate.
Of course this needs it's own setting.
If you agree I'd make a PR ready :)
(Basically just another switch + display: none; rule)
The text was updated successfully, but these errors were encountered: