Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blkdev_get_by_dev calls to accommodate new holder ops argument #63

Closed
wants to merge 1 commit into from
Closed

Update blkdev_get_by_dev calls to accommodate new holder ops argument #63

wants to merge 1 commit into from

Conversation

mbaehr
Copy link

@mbaehr mbaehr commented Oct 12, 2023

This is necessary to build on kernel 6.5 (installed w/ today's Ubuntu 23.10 release)

A new blk_holder_ops structure is available as an optional
argument for all blkdev_get_by_* calls. Update accordingly.

Kernel commit: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0718afd47f70cf46877c39c25d06b786e1a3f36c
@mbaehr
Copy link
Author

mbaehr commented Oct 14, 2023

@SergeiShtepa I am not sure if this is up to your coding standards but I wanted to let you know it did get me a successfully-building module on Ubuntu 23.10 w/ kernel 6.5.

As I am using ZFS, I have not yet actually able to test the blksnap functionality to be sure there is no regression in functionality w/ this kernel series. I intend to do further experimentation using a supported filesystem later.

@SergeiShtepa
Copy link
Collaborator

Hi!
Thank you for your pull request.

I already support lk 6.5 in the branch VAL-6.1 and merge this fix into VAL-6.0 (I published it only today).
This should work for lk 6.6 as well.

The code from the VAL-6.0 branch is considered stable and is supported by Veeam and I advise you to use it.

In these branches, the module is being developed, which is part of the Veeam Agent for Linux product release 6.0 and next release 6.1. Alas, the master branch is outdated. Perhaps I will update it in the future. I don't know yet.

@SergeiShtepa
Copy link
Collaborator

As I am using ZFS, I have not yet actually able to test the blksnap functionality to be sure there is no regression in functionality w/ this kernel series. I intend to do further experimentation using a supported filesystem later.

Let me remind you that the main task of the blksnap project is to create a patch for the Linux kernel upstream.
You can familiarize with it here. Tools for working with this version of the blksnap module are available in the branch.
I'm still testing this code. THIS IS UNSTABLE CODE.
I would appreciate it if you could find an opportunity to check the compatibility of the blksnap module with ZFS. It looks like fallocate has been supported. But alas, I have no plans to test compatibility with ZFS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants