80 Fix lint errors

.ansible-lint

@@ -1,2 +1,11 @@
 ---
 verbosity: 1
+
+skip_list:
+  - 'yaml'
+  - 'role-name'
+  - 'package-latest'
+  - 'latest[git]'
+  - 'no-changed-when'
+  - 'schema[meta]'
+  - 'ignore-errors'

inventory.yml

@@ -1,11 +1,12 @@
+---
 all:
-  # hosts:
-  #   atom:
-  #     ansible_ssh_port: 22
-  #     ansible_ssh_host: 192.168.0.120
-  #     ansible_ssh_user: veerendra
-  #     # ansible_ssh_password:
-  #     extra_hosts:
-  #       - "atom:192.168.0.130" # Wifi Address
+  hosts:
+    atom:
+      ansible_ssh_port: 22
+      ansible_ssh_host: 192.168.0.120
+      ansible_ssh_user: veerendra
+      # ansible_ssh_password:
+      extra_hosts:
+        - "atom:192.168.0.130"
   localhost:
-    ansible_connection: local
+    ansible_connection: local

main.yml

@@ -4,9 +4,9 @@
   vars_files:
     - vars.yml
 
-  roles:
-    - role: veerendra2.prepare_dev_setup
-      tags: system
+  # roles:
+  #   - role: veerendra2.prepare_dev_setup
+  #     tags: system
 
   tasks:
     - name: Prepare Pi
@@ -22,7 +22,3 @@
     - name: Setup firewall rules
       ansible.builtin.import_tasks: tasks/ufw.yml
       become: true
-
-    - name: Run smoke tests
-      ansible.builtin.import_tasks: tasks/smoke-tests.yml
-      tags: never

services/databases/docker-stack.yml

@@ -56,12 +56,12 @@ services:
       labels:
         - "traefik.enable=false"
     hostname: redis
-    command:  [
-    "sh", "-c",
-    '
-    docker-entrypoint.sh
-    --requirepass "$$(cat $$REDIS_PASSWORD_FILE)"
-    '
+    command: [
+      "sh", "-c",
+      '
+      docker-entrypoint.sh
+      --requirepass "$$(cat $$REDIS_PASSWORD_FILE)"
+      '
     ]
     env_file:
       - .env_redis

services/filebrowser/docker-stack.yml

@@ -35,4 +35,3 @@ services:
       - /media/disk1:/srv/disk1
     networks:
       network_public:
-

services/monitoring/grafana/provisioning/dashboards/dashboard.yml

@@ -1,3 +1,4 @@
+---
 apiVersion: 1
 
 providers:
@@ -9,4 +10,4 @@ providers:
     editable: true
     allowUiUpdates: true
     options:
-      path: /etc/grafana/provisioning/dashboards
+      path: /etc/grafana/provisioning/dashboards

services/monitoring/grafana/provisioning/datasources/datasource.yml

@@ -1,3 +1,4 @@
+---
 apiVersion: 1
 
 datasources:

services/monitoring/prometheus/prometheus.yml

@@ -1,3 +1,4 @@
+---
 global:
   scrape_interval: 15s
   evaluation_interval: 15s
@@ -8,8 +9,8 @@ global:
     monitor: "docker-host-alpha"
 
 # Load and evaluate rules in this file every 'evaluation_interval' seconds.
-#rule_files:
-#  - "alert.rules"
+# rule_files:
+#   - "alert.rules"
 
 # A scrape configuration containing exactly one endpoint to scrape.
 scrape_configs:

services/portainer/docker-stack.yml

@@ -42,4 +42,3 @@ services:
       - network_public
     secrets:
       - portainer_admin_password
-

services/rest-server/docker-stack.yml

@@ -1,3 +1,4 @@
+---
 version: "3.8"
 
 networks:
@@ -37,4 +38,4 @@ services:
       - network_public
       - network_monitoring
     secrets:
-      - htpasswd
+      - htpasswd

services/searxng/config/settings.yml

@@ -1,3 +1,4 @@
+---
 general:
   # Debug mode, only for development. Is overwritten by ${SEARXNG_DEBUG}
   debug: false

services/searxng/docker-stack.yml

@@ -1,3 +1,4 @@
+---
 version: "3.8"
 
 networks:

services/traefik/docker-stack.yml

@@ -1,3 +1,4 @@
+---
 # https://dust6765.gitbook.io/raspberrypi-home-server/services/traefik-proxy
 version: "3.8"
 
@@ -51,4 +52,4 @@ services:
       - network_public
       - network_private
     secrets:
-      - duckdns
+      - duckdns

services/traefik/network.yml

@@ -1,3 +1,4 @@
+---
 version: '3.8'
 
 services:

services/vaultwarden/docker-stack.yml

@@ -1,3 +1,4 @@
+---
 version: '3.8'
 
 networks:

tasks/deploy-services.yml

@@ -4,17 +4,20 @@
     path: "{{ services_base_dir_location }}"
     state: directory
     owner: "{{ run_user }}"
-  become: yes
+    mode: '0644'
+  become: true
 
-# Run pre deploy tasks for services
-- include_tasks: pihole.yml
+- name: Include pihole tasks
+  ansible.builtin.include_tasks: pihole.yml
   when: "'pihole' in services"
 
 - name: Create .vpn_ip file for torrent service
   ansible.builtin.copy:
     dest: services/torrent/.vpn_ip
     content: |
       VPN_IP={{ vpn_ip }}
+    owner: "{{ run_user }}"
+    mode: '0644'
   when: "vpn_ip and 'torrent' in services"
 
 - name: Synchronize services directories

tasks/pigpio.yml

@@ -9,6 +9,8 @@
   ansible.builtin.get_url:
     url: https://github.com/joan2937/pigpio/archive/master.zip
     dest: "{{ tempdir.path }}"
+    owner: "{{ run_user }}"
+    mode: '0440'
 # TODO need to test!
 - name: Extract pigpio
   ansible.builtin.unarchive:
@@ -24,7 +26,6 @@
 
 - name: Set systemd unit parameters for pigpiod
   ansible.builtin.set_fact:
-    name: pigpiod
     description: Daemon required to control GPIO pins via pigpio
     exec_start_cmd: /usr/local/bin/pigpiod
     exec_kill_cmd: /bin/systemctl kill pigpiod
@@ -37,12 +38,13 @@
   ansible.builtin.template:
     src: templates/systemd_unit.service.j2
     dest: /lib/systemd/system/pigpiod.service
+    mode: '0640'
 
 - name: Enable and start pigpiod systemd daemon
   ansible.builtin.systemd:
     name: pigpiod
-    enabled: yes
-    daemon_reload: yes
+    enabled: true
+    daemon_reload: true
     state: started
 
 - name: Copy fan.py script
@@ -53,7 +55,6 @@
 
 - name: Set systemd unit parameters for fan-py
   ansible.builtin.set_fact:
-    name: fan-py
     description: Daemon required to control fan speed via pigpio
     exec_start_cmd: /usr/bin/python3 /usr/local/bin/fan.py
     exec_kill_cmd: /bin/kill -TERM $MAINPID
@@ -62,14 +63,15 @@
     pre_start_cmd: /bin/sleep 5
     service_type: simple
 
-- name: Create fan-py systemd unit
+- name: Create fan-py systemd unit file
   ansible.builtin.template:
     src: templates/systemd_unit.service.j2
     dest: /lib/systemd/system/fan-py.service
+    mode: '0640'
 
 - name: Enable and start fan-py systemd daemon
   ansible.builtin.systemd:
     name: fan-py
-    enabled: yes
-    daemon_reload: yes
+    enabled: true
+    daemon_reload: true
     state: started

tasks/pihole.yml

@@ -2,32 +2,32 @@
 # https://github.com/pi-hole/docker-pi-hole#installing-on-ubuntu-or-fedora
 
 - name: Disable stub resolver in systemd-resolved config
-  ini_file:
+  community.general.ini_fil:
     path: /etc/systemd/resolved.conf
     section: Resolve
     option: DNSStubListener
     value: "no"
     backup: true
 
 - name: Create backup /etc/resolv.conf
-  copy:
-    remote_src: yes
+  ansible.builtin.copy`:
+    remote_src: true
     src: /etc/resolv.conf
     dest: /etc/resolv.conf.backup
 
 - name: Remove /etc/resolv.conf
-  file:
+  ansible.builtin.file:
     path: /etc/resolv.conf
     state: absent
 
 - name: Create link /etc/resolv.conf
-  file:
+  ansible.builtin.file:
     src: /run/systemd/resolve/resolv.conf
     dest: /etc/resolv.conf
     state: link
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: Restart systemd-resolved
-  service:
+  ansible.builtin.service:
     name: systemd-resolved
     state: restarted

tasks/prepare-pi.yml

@@ -1,5 +1,6 @@
 ---
 - name: Install fan script
+  when: install_fan_script
   block:
     - name: Check fan-py daemon is loaded
       ansible.builtin.systemd:
@@ -9,21 +10,20 @@
     - name: Install pigpio and Pi fan controller
       ansible.builtin.include_tasks: pigpio.yml
       when: output.status.LoadState != 'loaded'
-  when: install_fan_script
 
 - name: Power optimization
+  when: disable_bluetooth
   block:
     - name: Stop and disable hciuart and bluetooth deamon
       ansible.builtin.systemd:
         name: "{{ item }}"
         state: stopped
-        enabled: no
+        enabled: false
       with_items:
         - bluetooth
         - hciuart
     - name: Disable HDMI Output
       ansible.builtin.command: /usr/bin/tvservice -o
-  when: disable_bluetooth|bool == true
 
 - name: Configure disk mounts in /etc/fstab
   ansible.posix.mount: