Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modulaiton.py PSKModem constellation not using numpy array #28

Closed
elysoto opened this issue Apr 1, 2019 · 1 comment
Closed

modulaiton.py PSKModem constellation not using numpy array #28

elysoto opened this issue Apr 1, 2019 · 1 comment

Comments

@elysoto
Copy link

elysoto commented Apr 1, 2019

self.constellation = map(self._constellation_symbol,
self.symbol_mapping)

in the constructor, should be

self.constellation = array(map(self._constellation_symbol,
self.symbol_mapping))

similar to what QAMModem is doing.

Otherwise, this type error occurs.
TypeError: list indices must be integers, not list

@BastienTr
Copy link
Collaborator

Hi Elysoto,

Can you check that this issue still occures when cloning the GitHub repo rather than using the pip version ? In modulation.py lines 116/117 :
self.constellation = list(map(self.constellation, self.symbol_mapping)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants