You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have noted that the constellation mapping implemented is not actually the Gray mapping. Because of that, e.g. for high order QAM, there is a performance mismatch with respect to the theoretical BER vs SNR curves for the AWGN channel, if one tries to use the QAMModem methods to modulate and demodulate a sequence of bits and compute the BER afterward.
The text was updated successfully, but these errors were encountered:
You're right. Gray mapping is a feature that we are asked. At the moment, I'm almost alone to take care of CommPy on a day by day basis and I don't have the time to look after new features... If you ever had time to make this change and open a PR, it would be really enjoyed!
I close this issue as it's a duplicate of #60, we can continue the conversation there.
I have noted that the constellation mapping implemented is not actually the Gray mapping. Because of that, e.g. for high order QAM, there is a performance mismatch with respect to the theoretical BER vs SNR curves for the AWGN channel, if one tries to use the QAMModem methods to modulate and demodulate a sequence of bits and compute the BER afterward.
The text was updated successfully, but these errors were encountered: