Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constellation mapping implemented for MQAM is not the Gray mapping #99

Closed
edsonportosilva opened this issue Jan 31, 2021 · 1 comment
Closed

Comments

@edsonportosilva
Copy link
Contributor

I have noted that the constellation mapping implemented is not actually the Gray mapping. Because of that, e.g. for high order QAM, there is a performance mismatch with respect to the theoretical BER vs SNR curves for the AWGN channel, if one tries to use the QAMModem methods to modulate and demodulate a sequence of bits and compute the BER afterward.

@BastienTr
Copy link
Collaborator

You're right. Gray mapping is a feature that we are asked. At the moment, I'm almost alone to take care of CommPy on a day by day basis and I don't have the time to look after new features... If you ever had time to make this change and open a PR, it would be really enjoyed!

I close this issue as it's a duplicate of #60, we can continue the conversation there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants