Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sometimes an unexpected identity file path is parsed #3

Merged

Conversation

veeso
Copy link
Owner

@veeso veeso commented Feb 2, 2023

ISSUE 2 - Sort hosts after parsing

Fixes #2

Description

  • Hosts are sorted by priority after parsing

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I checked my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • The changes I've made are Windows, MacOS, Linux compatible (or I've handled them using cfg target_os)
  • I increased or maintained the code coverage for the project, compared to the previous commit

@veeso veeso added the bug Something isn't working label Feb 2, 2023
@veeso veeso self-assigned this Feb 2, 2023
@veeso veeso linked an issue Feb 2, 2023 that may be closed by this pull request
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4076532444

  • 27 of 40 (67.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.03%) to 97.681%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 18 19 94.74%
src/host.rs 9 21 42.86%
Totals Coverage Status
Change from base Build 4072830173: -1.03%
Covered Lines: 1095
Relevant Lines: 1121

💛 - Coveralls

@veeso veeso merged commit 43ecafe into main Feb 2, 2023
@veeso veeso deleted the 2-bug-sometimes-an-unexpected-identity-file-path-is-parsed branch February 2, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Sometimes an unexpected identity file path is parsed
2 participants