Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default constructor #7

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Conversation

dev-ardi
Copy link
Contributor

Add default constructor

Description

Added a default constructor so that people only need to call ssh2_config::SshConfig::parse_default_file

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I checked my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • The changes I've made are Windows, MacOS, Linux compatible (or I've handled them using cfg target_os)
  • I increased or maintained the code coverage for the project, compared to the previous commit

Acceptance tests

wait for a project maintainer to fulfill this section...

  • regression test: ...

@veeso veeso merged commit f4aa49d into veeso:main Jul 28, 2023
2 checks passed
@dev-ardi
Copy link
Contributor Author

Thanks for merging!

@dev-ardi
Copy link
Contributor Author

dev-ardi commented Aug 2, 2023

@veeso why has this been made unix only?

@coveralls
Copy link

coveralls commented Jan 18, 2024

Pull Request Test Coverage Report for Build 5692619229

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.702%

Totals Coverage Status
Change from base Build 5692582296: 0.0%
Covered Lines: 1148
Relevant Lines: 1175

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants