Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands as enum #11

Merged
merged 2 commits into from
Dec 7, 2021
Merged

commands as enum #11

merged 2 commits into from
Dec 7, 2021

Conversation

veeso
Copy link
Owner

@veeso veeso commented Dec 7, 2021

Command as enum

Description

  • Use an enum Command instead of strings for performing commands

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I linted my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have introduced no C-bindings
  • I increased or maintained the code coverage for the project, compared to the previous commit

Acceptance tests

wait for a project maintainer to fulfill this section...

  • regression test: regression test on entire library

@veeso veeso changed the base branch from main to 4.2.0 December 7, 2021 14:29
@veeso veeso added the enhancement New feature or request label Dec 7, 2021
@veeso veeso merged commit d13d316 into 4.2.0 Dec 7, 2021
@veeso veeso deleted the commands-as-enum branch December 7, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant