Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EPSV (Extended Passive Mode) #29

Merged
merged 9 commits into from
Feb 1, 2023

Conversation

veeso
Copy link
Owner

@veeso veeso commented Feb 1, 2023

ISSUE 28 - Implement EPSV (Extended Passive Mode)

Fixes #28

Description

Implementation of EPSV according to RFC 2428, section 3. See also https://www.jscape.com/blog/what-is-the-ftp/s-epsv-command-and-when-do-you-use-it

  • Implemented EPSV on Sync client
  • Implemented EPSV on Async client
  • Updated suppaftp-cli to support EPSV
  • Updated cargo dependencies
  • Updated documentation to talk about EPSV

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I linted my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have introduced no C-bindings
  • I increased or maintained the code coverage for the project, compared to the previous commit

Acceptance tests

  • regression test: normal passive mode still works
  • I can transfer files with EPSV mode

@veeso veeso added the new feature A new feature request label Feb 1, 2023
@veeso veeso self-assigned this Feb 1, 2023
@veeso veeso linked an issue Feb 1, 2023 that may be closed by this pull request
@veeso veeso marked this pull request as draft February 1, 2023 09:29
@veeso
Copy link
Owner Author

veeso commented Feb 1, 2023

test.rebex.net has issues with login...

@veeso veeso marked this pull request as ready for review February 1, 2023 11:23
@veeso veeso merged commit 0d97ea2 into main Feb 1, 2023
@veeso veeso deleted the 28-feature-request-implement-epsv-extended-passive-mode branch February 1, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] - Implement EPSV (Extended Passive Mode)
1 participant