Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33 bug features are not additive #34

Merged
merged 4 commits into from
Feb 24, 2023
Merged

Conversation

veeso
Copy link
Owner

@veeso veeso commented Feb 24, 2023

ISSUE 33 - Additive features

Fixes #33

Description

  • Issue 33 ‼️ BREAKING CHANGES ‼️
    • Features are now additive. This means that you can successfully build suppaftp with all the features enabled at the same time.
    • Ftp stream has now been split into different types:
      • FtpStream: sync no-tls stream
      • NativeTlsFtpStream: ftp stream with TLS with native-tls
      • RustlsFtpStream: ftp stream with TLS with rustls
      • AsyncFtpStream: async no-tls stream
      • AsyncNativeTlsFtpStream: async ftp stream with TLS with async-native-tls
      • AsyncRustlsFtpStream: async ftp stream with TLS with async-rustls

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@veeso veeso linked an issue Feb 24, 2023 that may be closed by this pull request
@veeso veeso merged commit 7b252ed into main Feb 24, 2023
@veeso veeso deleted the 33-bug-features-are-not-additive branch February 24, 2023 15:04
@OvermindDL1
Copy link

Awesome, thanks! You're fantastic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - features are not additive
2 participants