Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Build badge was using an incorrect path resulting in false "failed" status #83

Merged
merged 1 commit into from
May 23, 2024

Conversation

tadghh
Copy link
Contributor

@tadghh tadghh commented May 22, 2024

I think it was using and outdated format.

New: https://github.com/veeso/suppaftp/actions/workflows/cargo.yml/badge.svg

Old: https://github.com/veeso/suppaftp/workflows/Build/badge.svg

Description

The build badge was reporting previous builds as if they were failing. The Actions page says otherwise. With builds being incorrectly reported as failed, it might deter people from using suppaftp.

List here your changes

  • Updated the SVG path for the build badge on the projects readme

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I linted my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have introduced no C-bindings
  • I increased or maintained the code coverage for the project, compared to the previous commit

Acceptance tests

wait for a project maintainer to fulfill this section...

  • regression test: ...

@veeso veeso merged commit a99b742 into veeso:main May 23, 2024
4 checks passed
@veeso
Copy link
Owner

veeso commented May 23, 2024

thank you!

@tadghh tadghh deleted the patch-1 branch May 24, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants