Refactoring FtpFileTransfer::parse_unix_list_line #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 0.3.1 #4 +/- ##
==========================================
+ Coverage 85.20% 85.36% +0.16%
==========================================
Files 22 22
Lines 4624 4586 -38
==========================================
- Hits 3940 3915 -25
+ Misses 684 671 -13
Continue to review full report at Codecov.
|
|
I totally forgot to refactor that snippet of code, which I've written while testing the parser 😆. Thank you very much! |
veeso
added a commit
that referenced
this pull request
Jun 13, 2021
# This is the 1st commit message: Use containers to test file transfers # This is the commit message #2: Container setup # This is the commit message #3: Container setup # This is the commit message #4: tests with docker-compose # This is the commit message #5: these tests won't work with containers # This is the commit message #6: ftp tests with containers; removed crap servers; tests only lib # This is the commit message #7: hostname for github # This is the commit message #8: booooooh # This is the commit message #9: fixed recursive remove FTP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a refactoring of a code by converting some duplicate code to clojure.