Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.0 #4

Merged
merged 8 commits into from
May 15, 2021
Merged

0.3.0 #4

merged 8 commits into from
May 15, 2021

Conversation

veeso
Copy link
Owner

@veeso veeso commented May 13, 2021

tui-realm 0.3.0

Description

  • Changed PropValue API to be similiar to the Msg API. Now there are both PropPayload and PropValue as happens with Payload and Value.

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I checked my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have introduced no new C-bindings
  • The changes I've made are Windows, MacOS, UNIX, Linux compatible (or I've handled them using cfg target_os)
  • I increased or maintained the code coverage for the project, compared to the previous commit

@veeso veeso self-assigned this May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #4 (33fe9d9) into main (2d07d9f) will decrease coverage by 0.53%.
The diff coverage is 78.57%.

❗ Current head 33fe9d9 differs from pull request most recent head 85b7d0b. Consider uploading reports for the commit 85b7d0b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   83.22%   82.68%   -0.54%     
==========================================
  Files          16       16              
  Lines        1180     1190      +10     
==========================================
+ Hits          982      984       +2     
- Misses        198      206       +8     
Impacted Files Coverage Δ
src/props/mod.rs 100.00% <ø> (ø)
src/view.rs 96.29% <ø> (ø)
src/components/checkbox.rs 79.48% <64.70%> (-3.37%) ⬇️
src/components/input.rs 80.79% <100.00%> (-1.33%) ⬇️
src/components/progress_bar.rs 83.01% <100.00%> (ø)
src/components/radio.rs 85.22% <100.00%> (ø)
src/components/scrolltable.rs 79.67% <100.00%> (-0.33%) ⬇️
src/props/builder.rs 80.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a13d5...85b7d0b. Read the comment docs.

@veeso veeso marked this pull request as ready for review May 15, 2021 09:21
@veeso veeso merged commit 73c836e into main May 15, 2021
@veeso veeso deleted the 0.3.0 branch May 15, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant