Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ratatui dependency to version 0.26 #69

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

airstrike
Copy link
Contributor

68 - Update ratatui dependency to version 0.26

Fixes #68

Description

Updated ratatui dependency

List here your changes

  • Updated Cargo.toml to point to ratatui 0.26
  • I made also removed the generic argument in src/adapter/crossterm/mod.rs since Frame now takes none:
error[E0107]: struct takes 0 generic arguments but 1 generic argument was supplied
  --> src/adapter/crossterm/mod.rs:23:22
   |
23 | pub type Frame<'a> = TuiFrame<'a, CrosstermBackend<Stdout>>;
   |                      ^^^^^^^^     ------------------------ help: remove this generic argument
   |                      |
   |                      expected 0 generic arguments
   |
note: struct defined here, with 0 generic parameters
  --> /Users/andy/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ratatui-0.26.1/src/terminal/frame.rs:14:12
   |
14 | pub struct Frame<'a> {
   |            ^^^^^

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I checked my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have introduced no new C-bindings
  • The changes I've made are Windows, MacOS, UNIX, Linux compatible (or I've handled them using cfg target_os)
  • I increased or maintained the code coverage for the project, compared to the previous commit

@veeso veeso merged commit 93ee9c6 into veeso:main Mar 4, 2024
7 checks passed
@veeso
Copy link
Owner

veeso commented Mar 4, 2024

thanks for your contribution

@airstrike airstrike deleted the update-ratatui-0.26 branch March 4, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Update ratatui dependency to 0.26
2 participants