Differences between legacy and new API

src/Xml/Dom/Assert/assert_cdata.php

@@ -4,15 +4,15 @@
 
 namespace VeeWee\Xml\Dom\Assert;
 
-use \DOM\CdataSection;
+use \DOM\CDATASection;
 use Psl\Type\Exception\AssertException;
 use function Psl\Type\instance_of;
 
 /**
- * @psalm-assert \DOM\CdataSection $node
+ * @psalm-assert \DOM\CDATASection $node
  * @throws AssertException
  */
-function assert_cdata(mixed $node): \DOM\CdataSection
+function assert_cdata(mixed $node): \DOM\CDATASection
 {
-    return instance_of(\DOM\CdataSection::class)->assert($node);
+    return instance_of(\DOM\CDATASection::class)->assert($node);
 }

src/Xml/Dom/Builder/cdata.php

@@ -5,20 +5,20 @@
 namespace VeeWee\Xml\Dom\Builder;
 
 use Closure;
-use \DOM\CdataSection;
+use \DOM\CDATASection;
 use \DOM\Node;
 use function VeeWee\Xml\Dom\Assert\assert_cdata;
 use function VeeWee\Xml\Dom\Locator\Node\detect_document;
 use function VeeWee\Xml\Internal\configure;
 
 /**
- * @param list<callable(\DOM\CdataSection): \DOM\CdataSection> $configurators
+ * @param list<callable(\DOM\CDATASection): \DOM\CDATASection> $configurators
  *
- * @return Closure(\DOM\Node): \DOM\CdataSection
+ * @return Closure(\DOM\Node): \DOM\CDATASection
  */
 function cdata(string $data, ...$configurators): Closure
 {
-    return static function (\DOM\Node $node) use ($data, $configurators): \DOM\CdataSection {
+    return static function (\DOM\Node $node) use ($data, $configurators): \DOM\CDATASection {
         $document = detect_document($node);
 
         return assert_cdata(

src/Xml/Dom/Builder/escaped_value.php

@@ -13,7 +13,8 @@
 function escaped_value(string $value): Closure
 {
     return static function (\DOM\Element $node) use ($value): \DOM\Element {
-        $node->nodeValue = htmlspecialchars($value, ENT_XML1|ENT_QUOTES);
+        // TODO : Add entity subtitution through appendXML ?
+        $node->textContent = htmlspecialchars($value, ENT_XML1|ENT_QUOTES);
 
         return $node;
     };

src/Xml/Dom/Builder/value.php

@@ -13,7 +13,8 @@
 function value(string $value): Closure
 {
     return static function (\DOM\Element $node) use ($value): \DOM\Element {
-        $node->nodeValue = $value;
+        // TODO : Add entity subtitution through appendXML ?
+        $node->textContent = $value;
 
         return $node;
     };

src/Xml/Dom/Collection/NodeList.php

@@ -59,6 +59,15 @@ public static function empty(): self
         return new self();
     }
 
+    /**
+     * @param \DOM\HTMLCollection $list
+     * @return NodeList<\DOM\Element>
+     */
+    public static function fromDOMHTMLCollection(\DOM\HTMLCollection $list): self
+    {
+        return new self(...values($list->getIterator()));
+    }
+
     /**
      * @template X of \DOM\Node
      * @param DOMNodeList<X> $list

src/Xml/Dom/Configurator/pretty_print.php

@@ -13,7 +13,8 @@
 function pretty_print(): Closure
 {
     return static function (\DOM\XMLDocument $document): \DOM\XMLDocument {
-        $document->preserveWhiteSpace = false;
+        // TODO :  not fully implemented yet in the new API
+        //$document->preserveWhiteSpace = false;
         $document->formatOutput = true;
 
         return $document;

src/Xml/Dom/Configurator/trim_spaces.php

@@ -13,7 +13,8 @@
 function trim_spaces(): Closure
 {
     return static function (\DOM\XMLDocument $document): \DOM\XMLDocument {
-        $document->preserveWhiteSpace = false;
+        // TODO :  not fully implemented yet in the new API
+        //$document->preserveWhiteSpace = false;
         $document->formatOutput = false;
 
         return $document;

src/Xml/Dom/Configurator/utf8.php

@@ -13,7 +13,7 @@
 function utf8(): Closure
 {
     return static function (\DOM\XMLDocument $document): \DOM\XMLDocument {
-        $document->encoding = 'UTF-8';
+        $document->charset = 'UTF-8';
 
         return $document;
     };

src/Xml/Dom/Document.php

@@ -14,10 +14,7 @@
 use VeeWee\Xml\ErrorHandling\Issue\IssueCollection;
 use VeeWee\Xml\Exception\RuntimeException;
 use function Psl\Vec\map;
-use function VeeWee\Xml\Dom\Configurator\loader;
-use function VeeWee\Xml\Dom\Loader\xml_file_loader;
-use function VeeWee\Xml\Dom\Loader\xml_node_loader;
-use function VeeWee\Xml\Dom\Loader\xml_string_loader;
+use function VeeWee\Xml\Dom\Loader;
 use function VeeWee\Xml\Dom\Locator\document_element;
 use function VeeWee\Xml\Dom\Mapper\xml_string;
 use function VeeWee\Xml\Internal\configure;
@@ -47,18 +44,28 @@ public static function configure(callable ... $configurators): self
     }
 
     /**
+     * @param callable(): XMLDocument $loader
      * @param list<callable(XMLDocument): XMLDocument> $configurators
      *
      * @throws RuntimeException
      */
-    public static function fromXmlFile(string $file, callable ...$configurators): self
+    public static function fromLoader(callable $loader, callable ...$configurators): self
     {
         return new self(
-            configure(...$configurators)(XMLDocument::createFromFile($file))
-            // TODO : What with loader(xml_file_loader($file))
+            configure(...$configurators)($loader())
         );
     }
 
+    /**
+     * @param list<callable(XMLDocument): XMLDocument> $configurators
+     *
+     * @throws RuntimeException
+     */
+    public static function fromXmlFile(string $file, callable ...$configurators): self
+    {
+        return self::fromLoader(Loader\xml_file_loader($file), ...$configurators);
+    }
+
     /**
      * @param non-empty-string $xml
      * @param list<callable(XMLDocument): XMLDocument> $configurators
@@ -67,10 +74,7 @@ public static function fromXmlFile(string $file, callable ...$configurators): se
      */
     public static function fromXmlString(string $xml, callable ...$configurators): self
     {
-        return new self(
-            configure(...$configurators)(XMLDocument::createFromString($xml))
-           // TODO : What with loader(xml_string_loader($file))
-        );
+        return self::fromLoader(Loader\xml_string_loader($xml), ...$configurators);
     }
 
     /**
@@ -80,10 +84,7 @@ public static function fromXmlString(string $xml, callable ...$configurators): s
      */
     public static function fromXmlNode(\DOM\Node $node, callable ...$configurators): self
     {
-        return self::configure(
-            loader(xml_node_loader($node)),
-            ...$configurators
-        );
+        return self::fromLoader(Loader\xml_node_loader($node), ...$configurators);
     }
 
     /**
@@ -93,9 +94,7 @@ public static function fromXmlNode(\DOM\Node $node, callable ...$configurators):
      */
     public static function fromUnsafeDocument(XMLDocument $document, callable ...$configurators): self
     {
-        return new self(
-            configure(...$configurators)($document)
-        );
+        return self::fromLoader(static fn () => $document, ...$configurators);
     }
 
     public function toUnsafeDocument(): XMLDocument

src/Xml/Dom/Loader/Loader.php

@@ -8,5 +8,5 @@
 
 interface Loader
 {
-    public function __invoke(\DOM\XMLDocument $document): void;
+    public function __invoke(): XMLDocument;
 }

src/Xml/Dom/Loader/xml_file_loader.php

@@ -5,21 +5,19 @@
 namespace VeeWee\Xml\Dom\Loader;
 
 use Closure;
-use \DOM\XMLDocument;
+use DOM\XMLDocument;
 use Webmozart\Assert\Assert;
+use function VeeWee\Xml\ErrorHandling\disallow_issues;
 
 /**
  * @param int $options - bitmask of LIBXML_* constants https://www.php.net/manual/en/libxml.constants.php
- * @return Closure(\DOM\XMLDocument): void
+ * @return Closure(): XMLDocument
  */
 function xml_file_loader(string $file, int $options = 0): Closure
 {
-    return static function (\DOM\XMLDocument $document) use ($file, $options): void {
-        load(
-            static function () use ($document, $file, $options): bool {
-                Assert::fileExists($file);
-                return $document->load($file, $options);
-            }
-        );
-    };
+    return static fn () => disallow_issues(static function () use ($file, $options): XMLDocument {
+        Assert::fileExists($file);
+
+        return XMLDocument::createFromFile($file, $options);
+    });
 }

src/Xml/Dom/Loader/xml_node_loader.php

@@ -6,16 +6,20 @@
 
 use Closure;
 use \DOM\XMLDocument;
-
 use \DOM\Node;
 use function VeeWee\Xml\Dom\Manipulator\Node\append_external_node;
+use function VeeWee\Xml\ErrorHandling\disallow_issues;
 
 /**
- * @return Closure(\DOM\XMLDocument): void
+ * @return Closure(): XMLDocument
  */
 function xml_node_loader(\DOM\Node $importedNode): Closure
 {
-    return static function (\DOM\XMLDocument $document) use ($importedNode): void {
-        load(static fn (): bool => (bool) append_external_node($document, $importedNode));
-    };
+    return static fn () => disallow_issues(static function () use ($importedNode): XMLDocument {
+        $document = XMLDocument::createEmpty();
+
+        append_external_node($document, $importedNode);
+
+        return $document;
+    });
 }

src/Xml/Dom/Loader/xml_string_loader.php

@@ -6,15 +6,16 @@
 
 use Closure;
 use \DOM\XMLDocument;
+use function VeeWee\Xml\ErrorHandling\disallow_issues;
 
 /**
  * @param non-empty-string $xml
  * @param int $options - bitmask of LIBXML_* constants https://www.php.net/manual/en/libxml.constants.php
- * @return Closure(\DOM\XMLDocument): void
+ * @return Closure(): XMLDocument
  */
 function xml_string_loader(string $xml, int $options = 0): Closure
 {
-    return static function (\DOM\XMLDocument $document) use ($xml, $options): void {
-        load(static fn (): bool => $document->loadXML($xml, $options));
-    };
+    return static fn () => disallow_issues(static function () use ($xml, $options): XMLDocument {
+        return XMLDocument::createFromString($xml, $options);
+    });
 }

src/Xml/Dom/Locator/Element/locate_by_namespaced_tag_name.php

@@ -12,5 +12,5 @@
  */
 function locate_by_namespaced_tag_name(\DOM\Element $node, string $namespace, string $localTagName): NodeList
 {
-    return NodeList::fromDOMNodeList($node->getElementsByTagNameNS($namespace, $localTagName));
+    return NodeList::fromDOMHTMLCollection($node->getElementsByTagNameNS($namespace, $localTagName));
 }

src/Xml/Dom/Locator/Element/locate_by_tag_name.php

@@ -12,5 +12,5 @@
  */
 function locate_by_tag_name(\DOM\Element $node, string $tag): NodeList
 {
-    return NodeList::fromDOMNodeList($node->getElementsByTagName($tag));
+    return NodeList::fromDOMHTMLCollection($node->getElementsByTagName($tag));
 }

src/Xml/Dom/Locator/Node/detect_document.php

@@ -16,8 +16,5 @@
  */
 function detect_document(\DOM\Node $node): \DOM\XMLDocument
 {
-    $document = is_document($node) ? $node : $node->ownerDocument;
-    Assert::notNull($document, 'Expected to find an ownerDocument on provided \DOM\Node.');
-
-    return $document;
+    return is_document($node) ? $node : $node->ownerDocument;
 }

src/Xml/Dom/Locator/Node/value.php

@@ -19,5 +19,8 @@
  */
 function value(\DOM\Node $node, TypeInterface $type)
 {
-    return $type->coerce($node->nodeValue);
+    // TODO : nodeValue did entity substitution
+    // TODO : nodeValue returns null for elements
+    // TODO : How to best deal with this?
+    return $type->coerce($node->textContent ?? '');
 }

src/Xml/Dom/Manipulator/Element/rename.php

@@ -4,8 +4,6 @@
 
 namespace VeeWee\Xml\Dom\Manipulator\Element;
 
-use \DOM\Attr;
-use \DOM\Element;
 use \DOM\NameSpaceNode;
 use VeeWee\Xml\Exception\RuntimeException;
 use function VeeWee\Xml\Dom\Builder\element;
@@ -44,7 +42,8 @@ static function (\DOM\NameSpaceNode $attribute) use ($target, $newElement): void
     );
 
     attributes_list($target)->forEach(
-        static function (\DOM\Attr $attribute) use ($newElement): void {
+        static function (\DOM\Attr $attribute) use ($target, $newElement): void {
+            $target->removeAttributeNode($attribute);
             $newElement->setAttributeNode($attribute);
         }
     );