Type hint schemapi.py #3142
Merged
Type hint schemapi.py #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binste
force-pushed
the
type_hint_schemapi
branch
from
127a4e9
to
f83caa5
Compare
|
Thanks for working on this @binste! I'll take a look later this week if no one gets to it first |
jonmmease
approved these changes
Aug 9, 2023
altair/utils/schemapi.py
Outdated
| _wrapper_classes: Optional[Iterable[Type["SchemaBase"]]] = None, | ||
| # Type hints for this method would get rather complicated | ||
| # if we want to provide a more specific return type | ||
| ) -> Any: |
There was a problem hiding this comment.
Would _TSchemaBase work here? I seems like the returned object should be a SchemaBase subclass.
There was a problem hiding this comment.
When I used SchemaBase as a return type, I got an error for Chart.from_dict in api.py so I left it at that. But after your comment I revisited this and indeed the Chart.from_dict type was wrong :) -> Done in 2732c8f
|
Thanks for the review @jonmmease! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2951 for an overview of the type hinting effort. For some methods which construct classes based on their input parameters I took the shortcut of typing them as
Anyfor now as I think to make it more specific we would need some more complicated type hints. These are not super relevant for users anyway but happy to take suggestions on how to improve it!We need to keep the type of
UndefinedasAnyas long as not all parts of the code are type hinted whereUndefinedis used. Afterwards we can change it to the properUndefinedType.