Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to gist form #28

Merged
merged 2 commits into from
Feb 20, 2018
Merged

Add validation to gist form #28

merged 2 commits into from
Feb 20, 2018

Conversation

saurabh0402
Copy link
Contributor

@saurabh0402 saurabh0402 commented Feb 20, 2018 •
edited

Solves #28

@domoritz
Copy link
Member

I think we should accept both URLs and user/gist-id strings. Can you change the matching to include the latter?

@saurabh0402
Copy link
Contributor Author

I have changed the Regular expression to allow user/gist-id.

@domoritz domoritz merged commit 50abff2 into vega:master Feb 20, 2018
@domoritz
Copy link
Member

Thanks. Merged with some code fixes.

@domoritz domoritz mentioned this pull request Feb 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saurabh0402 @domoritz