Space out header

[algomaster99]

Header

• onSelectNewVegaLite is being repeated in file src/components/input-panel/spec-editor/renderer.tsx and src/components/header/renderer.tsx.
• This is marked WIP since the header requires some minor CSS fixes to improve spacing between the buttons.

[domoritz]

Looks good so far. When you finish the CSS, I will do a thorough review and approve.

[algomaster99]

@domoritz

How are things looking?

[algomaster99]

@domoritz I am quite fine with adding the Share URL button one level deep inside export. But I am open to changes.

[domoritz]

@domoritz I am quite fine with adding the Share URL button one level deep inside export. But I am open to changes.

We had a lengthy discussion about this on Slack. It would be better to have it at the top level since share isn't part of export.

[algomaster99]

@domoritz

Share button has been restored.

[algomaster99]

@domoritz Shall we merge this?

[domoritz]

• Add back GIST loading
• Make format work (should use compact format)
• Update the help docs. We don't need to suggest F1 anymore. We should instead explain some common functionalities like formatting, clearing, ...
• Rename "Options" to "Commands"

[domoritz]

@siddhant1 We also need the help dialog cleanup for these changes (e.g. we want to docs links to be at the top of the help dialog).

[algomaster99]

@domoritz Format works if you run it through the command palette.

[domoritz]

Not for me:

[algomaster99]

@domoritz It initially too worked like this.

I think it is a problem with the Monaco editor's formatter.

[algomaster99]

@domoritz I am thinking to modify it like this:

[domoritz]

I think it is a problem with the Monaco editor's formatter.

Yep: microsoft/monaco-editor#889

[algomaster99]

@domoritz Check the help modal too

[domoritz]

Looks good. Let's move the docs links up.

[algomaster99]

@domoritz Done!

[domoritz]

Format still doesn't work correctly for me. I unchecked #379 (comment).

Can you move the references above the shortcuts?

[algomaster99]

[algomaster99]

@domoritz

[siddhant1]

This looks too good!

[domoritz]

Bugs I found:

• The run button doesn't catch clicks on the whole button.
• Cannot run at all in automatic mode.
• Switching from manual to automatic moves the v

[algomaster99]

@domoritz

• Cannot run at all in automatic mode.

I am not sure if I get this. What is the problem exactly?

[domoritz]

Just two small things and then we are good to go.