Simplify modal structure #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algomaster99
force-pushed
the
simplify-modal-code
branch
from
a7f42ce
to
1229b23
Compare
This comment has been minimized.
This comment has been minimized.
domoritz
reviewed
Jul 27, 2019
| <div className="modal modal-top" onClick={e => e.stopPropagation()}> | ||
| <div className="modal-header"> | ||
| <div className="modal" onClick={e => e.stopPropagation()}> | ||
| <div> | ||
| <button className="close-button" onClick={closePortal}> | ||
| <X /> | ||
| </button> | ||
| </div> | ||
| <div className="modal-body"> |
There was a problem hiding this comment.
Can we get rid of the modal body div?
There was a problem hiding this comment.
@domoritz I tried but it is messing up with the examples modal and the close button is also getting misaligned. Can you try for yourself once again?
domoritz
approved these changes
Jul 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405
I have tried to remove redundancy as much as possible.