Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove unnecessary scrollbar (in few browsers) #46

Merged
merged 1 commit into from Mar 9, 2018

Conversation

ydlamba
Copy link
Member

@ydlamba ydlamba commented Mar 9, 2018

Fix: Remove extra scroll (in few browsers)

  • In few browsers (like Chrome 64.0), there is an unnecessary disabled scrollbar associated with chart container, which looks like this:
    image

  • After fix:
    image

@domoritz
Copy link
Member

domoritz commented Mar 9, 2018

Does the scrollbar also disappear if we set overflow to none? I'm not quite sure why it's necessary to hide a scrollbar (and I'm a bit scared to do so).

@ydlamba
Copy link
Member Author

ydlamba commented Mar 9, 2018

Well, there are two scrollbars right now in which the outer one is always disabled and the inner one is perfectly doing its job. So in my opinion, we don't need an extra scrollbar for any purpose.
Plus display: none is a better way to remove it than overflow: hidden since the former removes the element from the page while making overflow hidden leave its space behind.

display: none:
image

overflow: hidden:
image

Over to you.

@domoritz domoritz merged commit 67a9699 into master Mar 9, 2018
@domoritz domoritz deleted the ydl/scroll-fix branch March 9, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants