Upgrade to webpack 4

[ydlamba]

Currently, not correctly working for production. (Work in Progress)

Fixes #53, #61.

[domoritz]

Why do we need a build folder and don't build directly into the public folder?

[domoritz]

Ahh, I see. Maybe better name it deploy.

[ydlamba]

/dist: "distribution", the compiled code/library
I think dist is like more standard.

[domoritz]

No more favicon?

[ydlamba]

Actually, html-webpack-plugin was loading it from public but now I think it's better to add the favicon in index.html itself. Adding it back.

[domoritz]

• Delete deploy.sh

[domoritz]

The build works for me. Why do you say it doesn't work in production?

[domoritz]

• Reduce the number of chunks. 47 seems excessive unless I'm missing why they are necessary.

[domoritz]

In Vega-Lite, we use rsync -r instead of cp -r. Can you find out what's better and use the better one everywhere?

[ydlamba]

I have bundled everything in node_modules in a separate file vendors.chunk.js (no more 47 chunks).
Favicon is added back.
deploy.sh deleted.
Also, cp is replaced by rsync.
Now it's working in production too but few bundle sizes are large so webpack (in production) is showing size limit warnings.

[domoritz]

I think we want a few chunks so that downloads can run in parallel but not 47.

What's the difference between cp and rsync?

[ydlamba]

There is not much difference between cp and rsync in copying local files. Just I have seen rsync as a preferred tool in many places.

Rsync is better since it will only copy only the updated parts of the updated file, instead of the whole file. It also uses compression and encryption if you want.

[ydlamba]

I have limited the maximum number of chunks to 5 (I also tried with 10 but it was creating small chunks thereafter, not much helpful). Try it if it works.