Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests run only once #88

Closed
kanitw opened this issue Jan 31, 2015 · 0 comments
Closed

Make tests run only once #88

kanitw opened this issue Jan 31, 2015 · 0 comments
Labels
bug

Comments

@kanitw
Copy link
Member

kanitw commented Jan 31, 2015

From the vlplot test’s error, seems like tests are loaded twice….

PhantomJS 1.9.8 (Mac OS X) Directive: vlPlot should attach visualization FAILED
    Expected 0 to be 1.
        at /Users/kanitw/Dropbox/_Projects/_idl/_visrec/vegalite-ui/src/components/vlplot/vlplot.spec.js:42
        at invoke (/Users/kanitw/Dropbox/_Projects/_idl/_visrec/vegalite-ui/bower_components/angular/angular.js:4182)
        at workFn (/Users/kanitw/Dropbox/_Projects/_idl/_visrec/vegalite-ui/bower_components/angular-mocks/angular-mocks.js:2350)
PhantomJS 1.9.8 (Mac OS X) Directive: vlPlot should attach visualization FAILED
    Expected 0 to be 1.
        at /Users/kanitw/Dropbox/_Projects/_idl/_visrec/vegalite-ui/src/components/vlplot/vlplot.spec.js:42
        at invoke (/Users/kanitw/Dropbox/_Projects/_idl/_visrec/vegalite-ui/bower_components/angular/angular.js:4182)
        at workFn (/Users/kanitw/Dropbox/_Projects/_idl/_visrec/vegalite-ui/bower_components/angular-mocks/angular-mocks.js:2350)
@kanitw kanitw added the bug label Jan 31, 2015
domoritz added a commit that referenced this issue Feb 1, 2015
@domoritz
debounce in karma to avoid tests running twice. Fixes #88
0e3669b 
Not super clean but it works so seems good for now.
@domoritz domoritz mentioned this issue Feb 1, 2015
Merged
@kanitw kanitw closed this as completed in #94 Feb 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kanitw