New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Type Icons #43
Data Type Icons #43
Conversation
Can you change the type to the primitive type in the schmea? The data type is only defined once a field is dropped. We're mixing different concepts here. |
We really should have a proper conversation about data type. I don’t think we need to expose primitive data types (int, long, string) in the interface at all. It makes sense to expose “number”, “text”, “location”, “time”. However, the way we (and Tableau) treat ordinal, quantitative right now makes In reality, some text are ordinal, some are categorical, blah blah but if we want to distinguish text and ordinal then we should distinguish between ordinal / categorical? Otherwise, I can’t think of any benefits from doing this yet. |
Yes, right now we have the direct correspondence but in the code we should make the difference clear. For example, for the study, I'd say we should make numbers with a small cardinality (cylinders for example in the car dataset) ordinal. |
Okay. WIll ping you once I update |
(1) we're already using autoprefixer so there is no point to use both compass mix-ins and auto-prefixer (2) turn out that it takes too much time to setup compass in facetedviz so I think this is a corner that we can cut
Conflicts: app/scripts/services/dataset.js app/styles/vlui-common.scss
Conflicts: app/scripts/vendor/vegalite.js
Conflicts: app/scripts/services/dataset.js
@domoritz Now I remember what I wanted to ask you — it’s about this topic. We talked about two types of data types: primitive types and semantic types (I’ll call it role here) Originally you say we need to know primitive type in the system because the icon shows primitive types. But we should either have a custom schema file for each datasets we gonna use in the study For changing “default" role, I really think that we should have it on the left side. But allow casting on the right side. Now I summarize relationship between default role and supported casting role: roles that we can cast to ordinal/text: I put "ordinal/text, number/quantitative” above because I’m not sure how should we name things up there because it’s mixing between different ways of calling data types. In any case, selected role would affect supported function / scale type
What do you think? |
Note: schema overriding is not implemented yet.
Okay, now I modify the code and it should work Note that I use vegalite’s type as the type value that we pass around the system but display human friendly text (vlui type) in the UI. |
A lot of commits for a few changes but whateva. |
I had a stack overflow. Please don't add recursion to pr in the future. |
lol that's a typo. |
Add data type icons
Please merge #43 first!