add "copy" code commands using zero clipboard (fixes #32) #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kanitw
commented
Jan 21, 2015
kanitw
commented
- add "copy" code commands using zero clipboard (fixes Copy Code Using Zero Clipboard #32)
- add vl as constant for injection Refactor based on best practice #44
|
It's annoying when github cannot consolidate diffs... |
|
what do you mean? (your rant seems out of context here) |
Hehe. Yeah, now https://github.com/uwdata/vegalite-ui/pull/48/files is updated. Sometimes it takes a few minutes before they realize that we merged something else and update the diff accordingly. |
domoritz
added a commit
that referenced
this pull request
Jan 22, 2015
add "copy" code commands using zero clipboard (fixes #32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.