Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support top-level width and height #144

Merged
merged 3 commits into from
Mar 22, 2020
Merged

feat: support top-level width and height #144

merged 3 commits into from
Mar 22, 2020

Conversation

kristw
Copy link
Member

@kristw kristw commented Mar 22, 2020

<Vega width={xxx} height={xxx} spec={xxx} />

The top-level width and height now should work on initialization and also will have precedent over width and height in spec.

Fix #79
Replace #143

@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #144 into master will increase coverage by 3.72%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   32.63%   36.36%   +3.72%     
==========================================
  Files          14       15       +1     
  Lines         144      154      +10     
  Branches       37       40       +3     
==========================================
+ Hits           47       56       +9     
- Misses         89       90       +1     
  Partials        8        8
Impacted Files Coverage Δ
...ckages/react-vega/src/utils/getUniqueFieldNames.ts 100% <ø> (ø) ⬆️
...s/react-vega/src/utils/combineSpecWithDimension.ts 100% <100%> (ø)
packages/react-vega/src/VegaEmbed.tsx 21.53% <33.33%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94ba1f1...f7fc762. Read the comment docs.

@netlify
Copy link

netlify bot commented Mar 22, 2020

Deploy preview for react-vega ready!

Built with commit f7fc762

https://deploy-preview-144--react-vega.netlify.com

@kristw kristw merged commit 1d75bc3 into master Mar 22, 2020
@kristw kristw deleted the kristw--dim2 branch March 22, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing graph causes spec change each time the value changes.
1 participant