Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook doesn't rebuild when package sources change #46

Closed
domoritz opened this issue Jul 10, 2019 · 5 comments · Fixed by #54
Closed

Storybook doesn't rebuild when package sources change #46

domoritz opened this issue Jul 10, 2019 · 5 comments · Fixed by #54

Comments

@domoritz
Copy link
Member

I make changes in react-vega or react-vega-lite but storybook doesn't reload.
@hungngo97
Copy link
Member

Mine does change though, I changed some things on Vega.jsx, saved the file and it reloads

@domoritz
Copy link
Member Author

On master? I have to try again then. Did you run some lerna command?

@domoritz
Copy link
Member Author

Nope, doesn't work for me. Please post working instructions.

@hungngo97
Copy link
Member

I did yarn install && yarn build && yarn storybook from a fresh new cloned repo

@domoritz
Copy link
Member Author

And changes to the component source automatically trigger a rebuild? You don't have to run the command again?

@kristw kristw mentioned this issue Sep 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rewrite react-vega in typescript vega/react-vega
2 participants
@domoritz @hungngo97