-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite react-vega in typescript #54
Conversation
BREAKING: react-vega-lite is deprecated.
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 1
Lines ? 2
Branches ? 1
=======================================
Hits ? 2
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
Thank you ❤️ ! |
Should we use npm deprecate to tell people not to use the react-vega-lite package? |
@domoritz I haven't published I still have to update docs and add a few more things for perf, but at the least the storybook is working. Perhaps after official |
💔 BREAKING CHANGE:
react-vega
to mimicvega-embed
. The new<Vega />
component actually supports bothvega
andvega-lite
.<Vega />
already supportvega-lite
. I am deprecatingreact-vega-lite
and add lightweight convenient componentVegaLite
toreact-vega
instead.Internal
Fixes: #46, #47, #25, #23, #53