Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused static methods in Vega.jsx? #53

Closed
kanitw opened this issue Aug 10, 2019 · 2 comments
Closed

Remove unused static methods in Vega.jsx? #53

kanitw opened this issue Aug 10, 2019 · 2 comments

Comments

@kanitw
Copy link
Member

kanitw commented Aug 10, 2019

isSameSpec(a, b) isn't used (anymore), for example.
@domoritz
Copy link
Member

Yep, this will hopefully become obvious when we switch to typescript.

I'm curious where the check for equality went.

@kristw kristw mentioned this issue Sep 15, 2019
Merged
@kristw
Copy link
Member

kristw commented Sep 15, 2019

Fixed in #54

@kristw kristw closed this as completed Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kanitw @domoritz @kristw