Incorrect output for Generic with UnionType

[kanitw]

export type Condition<T> = {
  selection: LogicalOperand<string>;
} & T;

Condition<FieldDef|ValueDef> only has property selection but no properties from FieldDef and ValueDef.

See vega/vega-lite@06cc8dc in vega/vega-lite#1980.

Note that this is no longer a blocking issue since I redeclare this using Condition<FieldDef> | Condition<ValueDef> which is a better declaration anyway.

(I'm just filing the bug here so we are aware of this bug.)

[domoritz]

It works for me

export interface LogicalOperand<T> {
    foo: T;
}

export type Condition<T> = {
  selection: LogicalOperand<string>;
} & T;

export interface MyObject {
    bar: number;
}

export type MyType = Condition<MyObject>;

{
  "$ref": "#/definitions/MyType",
  "$schema": "http://json-schema.org/draft-04/schema#",
  "definitions": {
    "Condition<MyObject>": {
      "additionalProperties": false,
      "properties": {
        "bar": {
          "type": "number"
        },
        "selection": {
          "$ref": "#/definitions/LogicalOperand<string>"
        }
      },
      "required": [
        "bar",
        "selection"
      ],
      "type": "object"
    },
    "LogicalOperand<string>": {
      "additionalProperties": false,
      "properties": {
        "foo": {
          "type": "string"
        }
      },
      "required": [
        "foo"
      ],
      "type": "object"
    },
    "MyObject": {
      "additionalProperties": false,
      "properties": {
        "bar": {
          "type": "number"
        }
      },
      "required": [
        "bar"
      ],
      "type": "object"
    },
    "MyType": {
      "$ref": "#/definitions/Condition<MyObject>"
    }
  }
}

[kanitw]

export type MyType = Condition;

This doesn't have a union type inside Condition.

Try export type MyType = Condition<MyObject|TheirObject>; ?

[domoritz]

export type Condition<T> = {
  selection: T;
};

export interface A {
    foo: number;
    bar: number;
}

export interface B {
    bar: number;
    baz: number;
}

export type MyType = Condition<A | B>;

{
  "$ref": "#/definitions/MyType",
  "$schema": "http://json-schema.org/draft-04/schema#",
  "definitions": {
    "A": {
      "additionalProperties": false,
      "properties": {
        "bar": {
          "type": "number"
        },
        "foo": {
          "type": "number"
        }
      },
      "required": [
        "foo",
        "bar"
      ],
      "type": "object"
    },
    "B": {
      "additionalProperties": false,
      "properties": {
        "bar": {
          "type": "number"
        },
        "baz": {
          "type": "number"
        }
      },
      "required": [
        "bar",
        "baz"
      ],
      "type": "object"
    },
    "Condition<(A|B)>": {
      "additionalProperties": false,
      "properties": {
        "selection": {
          "anyOf": [
            {
              "$ref": "#/definitions/A"
            },
            {
              "$ref": "#/definitions/B"
            }
          ]
        }
      },
      "required": [
        "selection"
      ],
      "type": "object"
    },
    "MyType": {
      "$ref": "#/definitions/Condition<(A|B)>"
    }
  }
}

[domoritz]

See last comment. This works now.