Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the lint npm script to include all files in the test folder #844

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

simonlovesyou
Copy link
Contributor

As far as I can tell only these files were being covered by our lint script:

test/unit/AnnotatedTypeFormatter.test.ts
test/unit/String.test.ts
test/unit/deepMerge.test.ts
test/unit/intersectionOfArrays.test.ts
test/unit/isAssignableTo.test.ts

It should now cover all (but not the test fixtures, because I assume it we want it that way?)

package.json Outdated Show resolved Hide resolved
@domoritz domoritz enabled auto-merge (squash) July 7, 2021 19:51
@domoritz domoritz merged commit ac51046 into vega:master Jul 7, 2021
@simonlovesyou
Copy link
Contributor Author

Do you think we can disregard this failing step?

@domoritz
Copy link
Member

domoritz commented Jul 7, 2021

Windows needs glob's in double quotes, not single quotes. Fixed in 7b6104d.

@vega-org-bot
Copy link
Collaborator

🎉 This PR is included in version 0.94.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vega-org-bot vega-org-bot added the released This issue/pull request has been released. label Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants