fix: correctly apply conditional dash offsets (#6599)

fixes #6591
vega · Jun 9, 2020 · 7a973bf · 7a973bf
1 parent 634954d
commit 7a973bf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/axis.ts b/src/axis.ts
@@ -205,7 +205,7 @@ export const CONDITIONAL_AXIS_PROP_INDEX: Record<
   },
   gridDashOffset: {
     part: 'grid',
-    vgProp: 'strokeDash'
+    vgProp: 'strokeDashOffset'
   },
   gridOpacity: {
     part: 'grid',
@@ -225,7 +225,7 @@ export const CONDITIONAL_AXIS_PROP_INDEX: Record<
   },
   tickDashOffset: {
     part: 'ticks',
-    vgProp: 'strokeDash'
+    vgProp: 'strokeDashOffset'
   },
   tickOpacity: {
     part: 'ticks',

diff --git a/src/compile/axis/parse.ts b/src/compile/axis/parse.ts
@@ -286,7 +286,7 @@ function parseAxis(channel: PositionScaleChannel, model: UnitModel): AxisCompone
         // 2. Certain properties are always included (see `propsToAlwaysIncludeConfig`'s declaration for more details)
         (propsToAlwaysIncludeConfig.has(property) && hasConfigValue) ||
         // 3. Conditional axis values and signals
-        isConditionalAxisValue<any>(configValue) || // need to set "any" as TS isn't smart enough to figure the generic parameter type yet
+        isConditionalAxisValue(configValue) ||
         isSignalRef(configValue)
       ) {
         // If a config is specified and is conditional, copy conditional value from axis config