fix: don't include view stroke by default for non-cartesian plot (#7665)

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
vega · Aug 28, 2021 · 907518c · 907518c
1 parent aed088d
commit 907518c
Show file tree

Hide file tree

Showing 84 changed files with 131 additions and 100 deletions.
diff --git a/examples/compiled/airport_connections.vg.json b/examples/compiled/airport_connections.vg.json
@@ -5,7 +5,6 @@
   "padding": 5,
   "width": 900,
   "height": 500,
-  "style": "cell",
   "data": [
     {"name": "org_store"},
     {
@@ -263,6 +262,5 @@
       "range": [0, 1000],
       "zero": true
     }
-  ],
-  "config": {"style": {"cell": {"stroke": null}}}
+  ]
 }
diff --git a/examples/compiled/arc_donut.vg.json b/examples/compiled/arc_donut.vg.json
@@ -5,8 +5,6 @@
   "padding": 5,
   "width": 200,
   "height": 200,
-  "style": "cell",
-  "encode": {"update": {"stroke": {"value": null}}},
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/arc_facet.vg.json b/examples/compiled/arc_facet.vg.json
@@ -72,16 +72,14 @@
     {
       "name": "cell",
       "type": "group",
-      "style": "cell",
       "from": {
         "facet": {"name": "facet", "data": "source_0", "groupby": ["year"]}
       },
       "sort": {"field": ["datum[\"year\"]"], "order": ["ascending"]},
       "encode": {
         "update": {
           "width": {"signal": "child_width"},
-          "height": {"signal": "child_height"},
-          "stroke": {"value": null}
+          "height": {"signal": "child_height"}
         }
       },
       "marks": [

diff --git a/examples/compiled/arc_ordinal_theta.png b/examples/compiled/arc_ordinal_theta.png
diff --git a/examples/compiled/arc_ordinal_theta.svg b/examples/compiled/arc_ordinal_theta.svg
diff --git a/examples/compiled/arc_ordinal_theta.vg.json b/examples/compiled/arc_ordinal_theta.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 200,
   "height": 200,
-  "style": "cell",
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/arc_params.vg.json b/examples/compiled/arc_params.vg.json
@@ -80,7 +80,6 @@
       "type": "group",
       "name": "concat_0_group",
       "title": {"text": "Single Arc", "frame": "group"},
-      "style": "cell",
       "encode": {
         "update": {
           "width": {"signal": "childWidth"},
@@ -115,7 +114,6 @@
       "type": "group",
       "name": "concat_1_group",
       "title": {"text": "Stacked Arcs", "frame": "group"},
-      "style": "cell",
       "encode": {
         "update": {
           "width": {"signal": "childWidth"},
@@ -165,6 +163,5 @@
       "zero": true
     }
   ],
-  "legends": [{"fill": "color", "symbolType": "circle", "title": "category"}],
-  "config": {"style": {"cell": {"stroke": null}}}
+  "legends": [{"fill": "color", "symbolType": "circle", "title": "category"}]
 }
diff --git a/examples/compiled/arc_pie.vg.json b/examples/compiled/arc_pie.vg.json
@@ -5,8 +5,6 @@
   "padding": 5,
   "width": 200,
   "height": 200,
-  "style": "cell",
-  "encode": {"update": {"stroke": {"value": null}}},
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/arc_pie_pyramid.vg.json b/examples/compiled/arc_pie_pyramid.vg.json
@@ -5,8 +5,6 @@
   "padding": 5,
   "width": 200,
   "height": 200,
-  "style": "cell",
-  "encode": {"update": {"stroke": {"value": null}}},
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/arc_radial.vg.json b/examples/compiled/arc_radial.vg.json
@@ -5,8 +5,6 @@
   "padding": 5,
   "width": 200,
   "height": 200,
-  "style": "cell",
-  "encode": {"update": {"stroke": {"value": null}}},
   "data": [
     {"name": "source_0", "values": [12, 23, 47, 6, 52, 19]},
     {

diff --git a/examples/compiled/arc_radial_histogram.vg.json b/examples/compiled/arc_radial_histogram.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 200,
   "height": 200,
-  "style": "cell",
   "data": [
     {
       "name": "source_0",
@@ -165,6 +164,5 @@
       "bins": {"signal": "layer_1_bin_maxbins_10_IMDB_Rating_bins"},
       "zero": false
     }
-  ],
-  "config": {"style": {"cell": {"stroke": null}}}
+  ]
 }
diff --git a/examples/compiled/geo_choropleth.png b/examples/compiled/geo_choropleth.png
diff --git a/examples/compiled/geo_choropleth.svg b/examples/compiled/geo_choropleth.svg
diff --git a/examples/compiled/geo_choropleth.vg.json b/examples/compiled/geo_choropleth.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 500,
   "height": 300,
-  "style": "cell",
   "data": [
     {
       "name": "source_1",

diff --git a/examples/compiled/geo_circle.png b/examples/compiled/geo_circle.png
diff --git a/examples/compiled/geo_circle.svg b/examples/compiled/geo_circle.svg
diff --git a/examples/compiled/geo_circle.vg.json b/examples/compiled/geo_circle.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 500,
   "height": 300,
-  "style": "cell",
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/geo_constant_value.png b/examples/compiled/geo_constant_value.png
diff --git a/examples/compiled/geo_constant_value.svg b/examples/compiled/geo_constant_value.svg
diff --git a/examples/compiled/geo_constant_value.vg.json b/examples/compiled/geo_constant_value.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 500,
   "height": 300,
-  "style": "cell",
   "data": [
     {"name": "source_0", "url": "data/airports.csv", "format": {"type": "csv"}},
     {

diff --git a/examples/compiled/geo_custom_projection.vg.json b/examples/compiled/geo_custom_projection.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 900,
   "height": 560,
-  "style": "cell",
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/geo_graticule.png b/examples/compiled/geo_graticule.png
diff --git a/examples/compiled/geo_graticule.svg b/examples/compiled/geo_graticule.svg
diff --git a/examples/compiled/geo_graticule.vg.json b/examples/compiled/geo_graticule.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 200,
   "height": 200,
-  "style": "cell",
   "data": [{"name": "source_0", "transform": [{"type": "graticule"}]}],
   "projections": [
     {

diff --git a/examples/compiled/geo_graticule_object.png b/examples/compiled/geo_graticule_object.png
diff --git a/examples/compiled/geo_graticule_object.svg b/examples/compiled/geo_graticule_object.svg
diff --git a/examples/compiled/geo_graticule_object.vg.json b/examples/compiled/geo_graticule_object.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 200,
   "height": 200,
-  "style": "cell",
   "data": [
     {"name": "source_0", "transform": [{"type": "graticule", "step": [15, 15]}]}
   ],

diff --git a/examples/compiled/geo_layer.png b/examples/compiled/geo_layer.png
diff --git a/examples/compiled/geo_layer.svg b/examples/compiled/geo_layer.svg
diff --git a/examples/compiled/geo_layer.vg.json b/examples/compiled/geo_layer.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 500,
   "height": 300,
-  "style": "cell",
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/geo_layer_line_london.vg.json b/examples/compiled/geo_layer_line_london.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 700,
   "height": 500,
-  "style": "cell",
   "encode": {"update": {"stroke": {"value": "transparent"}}},
   "data": [
     {

diff --git a/examples/compiled/geo_line.png b/examples/compiled/geo_line.png
diff --git a/examples/compiled/geo_line.svg b/examples/compiled/geo_line.svg
diff --git a/examples/compiled/geo_line.vg.json b/examples/compiled/geo_line.vg.json
@@ -5,7 +5,6 @@
   "padding": 5,
   "width": 800,
   "height": 500,
-  "style": "cell",
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/geo_params_projections.png b/examples/compiled/geo_params_projections.png
diff --git a/examples/compiled/geo_params_projections.svg b/examples/compiled/geo_params_projections.svg
diff --git a/examples/compiled/geo_params_projections.vg.json b/examples/compiled/geo_params_projections.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 500,
   "height": 300,
-  "style": "cell",
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/geo_point.svg b/examples/compiled/geo_point.svg
diff --git a/examples/compiled/geo_point.vg.json b/examples/compiled/geo_point.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 500,
   "height": 300,
-  "style": "cell",
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/geo_repeat.png b/examples/compiled/geo_repeat.png
diff --git a/examples/compiled/geo_repeat.svg b/examples/compiled/geo_repeat.svg
diff --git a/examples/compiled/geo_repeat.vg.json b/examples/compiled/geo_repeat.vg.json
@@ -101,7 +101,6 @@
     {
       "type": "group",
       "name": "child__row_population_group",
-      "style": "cell",
       "encode": {
         "update": {
           "width": {"signal": "width"},
@@ -146,7 +145,6 @@
     {
       "type": "group",
       "name": "child__row_engineers_group",
-      "style": "cell",
       "encode": {
         "update": {
           "width": {"signal": "width"},
@@ -191,7 +189,6 @@
     {
       "type": "group",
       "name": "child__row_hurricanes_group",
-      "style": "cell",
       "encode": {
         "update": {
           "width": {"signal": "width"},

diff --git a/examples/compiled/geo_rule.png b/examples/compiled/geo_rule.png
diff --git a/examples/compiled/geo_rule.svg b/examples/compiled/geo_rule.svg
diff --git a/examples/compiled/geo_rule.vg.json b/examples/compiled/geo_rule.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 800,
   "height": 500,
-  "style": "cell",
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/geo_sphere.png b/examples/compiled/geo_sphere.png
diff --git a/examples/compiled/geo_sphere.svg b/examples/compiled/geo_sphere.svg
diff --git a/examples/compiled/geo_sphere.vg.json b/examples/compiled/geo_sphere.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 200,
   "height": 200,
-  "style": "cell",
   "data": [
     {"name": "source_0", "values": [{"type": "Sphere"}]},
     {"name": "source_1", "transform": [{"type": "graticule"}]}

diff --git a/examples/compiled/geo_text.png b/examples/compiled/geo_text.png
diff --git a/examples/compiled/geo_text.svg b/examples/compiled/geo_text.svg
diff --git a/examples/compiled/geo_text.vg.json b/examples/compiled/geo_text.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 800,
   "height": 500,
-  "style": "cell",
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/geo_trellis.png b/examples/compiled/geo_trellis.png
diff --git a/examples/compiled/geo_trellis.svg b/examples/compiled/geo_trellis.svg
diff --git a/examples/compiled/geo_trellis.vg.json b/examples/compiled/geo_trellis.vg.json
@@ -85,7 +85,6 @@
     {
       "name": "cell",
       "type": "group",
-      "style": "cell",
       "from": {
         "facet": {"name": "facet", "data": "source_0", "groupby": ["group"]}
       },

diff --git a/examples/compiled/layer_arc_label.vg.json b/examples/compiled/layer_arc_label.vg.json
@@ -5,8 +5,6 @@
   "padding": 5,
   "width": 200,
   "height": 200,
-  "style": "cell",
-  "encode": {"update": {"stroke": {"value": null}}},
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/point_angle_windvector.png b/examples/compiled/point_angle_windvector.png
diff --git a/examples/compiled/point_angle_windvector.svg b/examples/compiled/point_angle_windvector.svg
diff --git a/examples/compiled/point_angle_windvector.vg.json b/examples/compiled/point_angle_windvector.vg.json
@@ -5,7 +5,6 @@
   "padding": 5,
   "width": 615,
   "height": 560,
-  "style": "cell",
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/point_overlap.png b/examples/compiled/point_overlap.png
diff --git a/examples/compiled/point_overlap.svg b/examples/compiled/point_overlap.svg
diff --git a/examples/compiled/point_overlap.vg.json b/examples/compiled/point_overlap.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 20,
   "height": 20,
-  "style": "cell",
   "data": [
     {
       "name": "source_0",

diff --git a/examples/compiled/test_single_point_color.png b/examples/compiled/test_single_point_color.png
diff --git a/examples/compiled/test_single_point_color.svg b/examples/compiled/test_single_point_color.svg
diff --git a/examples/compiled/test_single_point_color.vg.json b/examples/compiled/test_single_point_color.vg.json
@@ -4,7 +4,6 @@
   "padding": 5,
   "width": 20,
   "height": 20,
-  "style": "cell",
   "data": [{"name": "source_0", "values": [{"a": 2}]}],
   "marks": [
     {

diff --git a/examples/specs/airport_connections.vl.json b/examples/specs/airport_connections.vl.json
@@ -86,6 +86,5 @@
   ],
   "projection": {"type": "albersUsa"},
   "width": 900,
-  "height": 500,
-  "config": {"view": {"stroke": null}}
+  "height": 500
 }
diff --git a/examples/specs/arc_donut.vl.json b/examples/specs/arc_donut.vl.json
@@ -15,6 +15,5 @@
   "encoding": {
     "theta": {"field": "value", "type": "quantitative"},
     "color": {"field": "category", "type": "nominal"}
-  },
-  "view": {"stroke": null}
+  }
 }
diff --git a/examples/specs/arc_facet.vl.json b/examples/specs/arc_facet.vl.json
@@ -6,8 +6,5 @@
     "column": {"field": "year"},
     "theta": {"field": "yield", "type": "quantitative", "aggregate": "sum"},
     "color": {"field": "site", "type": "nominal"}
-  },
-  "view": {
-    "stroke": null
   }
 }
diff --git a/examples/specs/arc_params.vl.json b/examples/specs/arc_params.vl.json
@@ -56,6 +56,5 @@
       "theta": {"field": "value", "type": "quantitative"},
       "color": {"field": "category", "type": "nominal"}
     }
-  }],
-  "config": {"view": {"stroke": null}}
+  }]
 }
diff --git a/examples/specs/arc_pie.vl.json b/examples/specs/arc_pie.vl.json
@@ -15,6 +15,5 @@
   "encoding": {
     "theta": {"field": "value", "type": "quantitative"},
     "color": {"field": "category", "type": "nominal"}
-  },
-  "view": {"stroke": null}
+  }
 }
diff --git a/examples/specs/arc_pie_pyramid.vl.json b/examples/specs/arc_pie_pyramid.vl.json
@@ -32,6 +32,5 @@
     "order": {
       "field": "order"
     }
-  },
-  "view": {"stroke": null}
+  }
 }
diff --git a/examples/specs/arc_radial.vl.json b/examples/specs/arc_radial.vl.json
@@ -16,6 +16,5 @@
     "theta": {"field": "data", "type": "quantitative", "stack": true},
     "radius": {"field": "data", "scale": {"type": "sqrt", "zero": true, "rangeMin": 20}},
     "color": {"field": "data", "type": "nominal", "legend": null}
-  },
-  "view": {"stroke": null}
+  }
 }
diff --git a/examples/specs/arc_radial_histogram.vl.json b/examples/specs/arc_radial_histogram.vl.json
@@ -29,6 +29,5 @@
       "aggregate": "count",
       "scale": {"type": "sqrt"}
     }
-  },
-  "config": {"view": {"stroke": null}}
+  }
 }
diff --git a/examples/specs/layer_arc_label.vl.json b/examples/specs/layer_arc_label.vl.json
@@ -22,6 +22,5 @@
     "encoding": {
       "text": {"field": "category", "type": "nominal"}
     }
-  }],
-  "view": {"stroke": null}
+  }]
 }
diff --git a/examples/specs/normalized/airport_connections_normalized.vl.json b/examples/specs/normalized/airport_connections_normalized.vl.json
@@ -87,6 +87,5 @@
     }
   ],
   "width": 900,
-  "height": 500,
-  "config": {"view": {"stroke": null}}
+  "height": 500
 }
diff --git a/examples/specs/normalized/arc_facet_normalized.vl.json b/examples/specs/normalized/arc_facet_normalized.vl.json
@@ -3,7 +3,6 @@
   "data": {"url": "data/barley.json"},
   "facet": {"column": {"field": "year"}},
   "spec": {
-    "view": {"stroke": null},
     "mark": "arc",
     "encoding": {
       "theta": {"field": "yield", "type": "quantitative", "aggregate": "sum"},