Manually declare SingleDefChannel as this leads to error with `npm ru…

…n schema`
vega · Jun 9, 2017 · b82b8ab · b82b8ab · domoritz · Jun 10, 2017
1 parent 46fbafe
commit b82b8ab
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/build/vega-lite-schema.json b/build/vega-lite-schema.json
@@ -621,7 +621,7 @@
         },
         "encodings": {
           "items": {
-            "type": "string"
+            "$ref": "#/definitions/SingleDefChannel"
           },
           "type": "array"
         },
@@ -4208,7 +4208,7 @@
         },
         "encodings": {
           "items": {
-            "type": "string"
+            "$ref": "#/definitions/SingleDefChannel"
           },
           "type": "array"
         },
@@ -4325,6 +4325,25 @@
         "string"
       ]
     },
+    "SingleDefChannel": {
+      "enum": [
+        "x",
+        "y",
+        "x2",
+        "y2",
+        "row",
+        "column",
+        "size",
+        "shape",
+        "color",
+        "opacity",
+        "text",
+        "tooltip"
+      ],
+      "type": [
+        "string"
+      ]
+    },
     "SortField": {
       "additionalProperties": false,
       "properties": {

diff --git a/src/channel.ts b/src/channel.ts
@@ -57,7 +57,10 @@ const CHANNEL_INDEX = toSet(CHANNELS);
 
 export const SINGLE_DEF_CHANNELS = [X, Y, X2, Y2, ROW, COLUMN, SIZE, SHAPE, COLOR, OPACITY, TEXT, TOOLTIP];
 
-export type SingleDefChannel = typeof SINGLE_DEF_CHANNELS[0];
+// export type SingleDefChannel = typeof SINGLE_DEF_CHANNELS[0];
+// FIXME somehow the typeof above leads to the following error when running npm run schema
+// UnknownNodeError: Unknown node "SingleDefChannel" (ts.SyntaxKind = 171) at /Users/kanitw/Documents/_code/_idl/_visrec/vega-lite/src/selection.ts(17,14)
+export type SingleDefChannel = 'x' | 'y' | 'x2' | 'y2' | 'row' | 'column' | 'size' | 'shape' | 'color' | 'opacity' | 'text' | 'tooltip';
 
 export function isChannel(str: string): str is Channel {
   return !!CHANNEL_INDEX[str];