Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transform extract tests #4419

Closed
kanitw opened this issue Dec 29, 2018 · 2 comments
Closed

Fix transform extract tests #4419

kanitw opened this issue Dec 29, 2018 · 2 comments
Labels
Area - Refactor 🏗️ Area - View Composition P2 Important Issues that should be fixed soon

Comments

@kanitw
Copy link
Member

kanitw commented Dec 29, 2018

We have almost 100 files that are in the fail list.

I think the number is a bit too high. I think we should fix this before moving on to other tasks. If we have like 10 that are hard to fix, I'll say that it's acceptable.
@domoritz domoritz mentioned this issue Dec 29, 2018
Closed
@kanitw kanitw added this to the x.x Composition Patches milestone Mar 3, 2019
@kanitw kanitw removed this from the x.x View Composition milestone Dec 4, 2019
@domoritz
Copy link
Member

We never finished this one either #4967

@domoritz domoritz added the P2 Important Issues that should be fixed soon label Jun 15, 2020
kanitw added a commit that referenced this issue Jun 18, 2020
@kanitw
fix: make transform extract only test boxplot and errorbar/band
0958e48 
part of #4419
@kanitw kanitw mentioned this issue Jun 18, 2020
Merged
kanitw added a commit that referenced this issue Jun 18, 2020
@kanitw
fix: make transform extract only test boxplot and errorbar/band
9c5a6f7 
part of #4419
@kanitw
Copy link
Member Author

kanitw commented Jun 18, 2020

I'm removing these in #6643.

@kanitw kanitw closed this as completed Jun 18, 2020
kanitw added a commit that referenced this issue Jun 18, 2020
@kanitw
fix: remove transformextract test
8234b03 
fix #4419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area - Refactor 🏗️ Area - View Composition P2 Important Issues that should be fixed soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kanitw @domoritz @Saba9