Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat spec raises error: Source nodes are roots and cannot be removed. #6897

Closed
domoritz opened this issue Sep 23, 2020 · 4 comments · Fixed by #6924
Closed

Concat spec raises error: Source nodes are roots and cannot be removed. #6897

domoritz opened this issue Sep 23, 2020 · 4 comments · Fixed by #6924
Assignees
Labels
Bug 🐛 P2 Important Issues that should be fixed soon

Comments

@domoritz
Copy link
Member

Source nodes are roots and cannot be removed.

Open the Chart in the Vega Editor

@intiocean
Copy link

intiocean commented Oct 13, 2020

I think this is happening to me - I've recently updated from 4.14.1 in production and now getting errors in the js console and charts aren't rendering. Going to roll back to 4.14.1 until this is released.

image

FYI I've tested with 4.15.0 and 4.16.1 and both have the same issue so assume this bug was introduced in 4.15.0

@domoritz
Copy link
Member Author

Did you test against master? Can you share your spec so we can try it?

@domoritz
Copy link
Member Author

I just made a release. Please try again.

@intiocean
Copy link

Hi - here's a spec generated using Altair that wasn't working - haven't yet had a chance to try it on the latest release but will let you know when I have.

{
  "$schema": "https://vega.github.io/schema/vega-lite/v4.8.1.json",
  "config": {
    "axis": {
      "labelFontSize": 12,
      "titleFontSize": 12
    },
    "legend": {
      "title": null
    },
    "view": {
      "continuousHeight": 300,
      "continuousWidth": 400
    }
  },
  "datasets": {
    "data-5f0f5ff84876a23e79b92d513f6417a5": [
      {
        "days": "1970-10-04T00:00:00",
        "y": -1
      },
      {
        "days": "1970-10-05T00:00:00",
        "y": -1
      },
      {
        "days": "1970-10-06T00:00:00",
        "y": -1
      },
      {
        "days": "1970-10-07T00:00:00",
        "y": -1
      },
      {
        "days": "1970-10-08T00:00:00",
        "y": -1
      },
      {
        "days": "1970-10-09T00:00:00",
        "y": -1
      },
      {
        "days": "1970-10-10T00:00:00",
        "y": -1
      },
      {
        "days": "1970-10-11T00:00:00",
        "y": -1
      }
    ],
    "data-9f2c8635c2b2a676ea596b4b4cb25013": [
      {
        "activity": "Treatment: C",
        "day": "2020-10-04T00:00:00+01:00",
        "day_sameyear": "1970-10-04T00:00:00",
        "notes": "xxx",
        "season": "2020-2021",
        "sector": "123 abc",
        "thing_id": 45195
      },
      {
        "activity": "Treatment: S",
        "day": "2020-10-11T00:00:00+01:00",
        "day_sameyear": "1970-10-11T00:00:00",
        "notes": "xxx",
        "season": "2020-2021",
        "sector": "123 abc",
        "thing_id": 45195
      }
    ]
  },
  "height": 90,
  "layer": [
    {
      "data": {
        "name": "data-5f0f5ff84876a23e79b92d513f6417a5"
      },
      "encoding": {
        "opacity": {
          "value": 0
        },
        "x": {
          "field": "days",
          "type": "temporal"
        }
      },
      "mark": "point",
      "selection": {
        "selector041": {
          "empty": "none",
          "fields": [
            "days"
          ],
          "nearest": true,
          "on": "mouseover",
          "type": "single"
        }
      }
    },
    {
      "data": {
        "name": "data-5f0f5ff84876a23e79b92d513f6417a5"
      },
      "encoding": {
        "x": {
          "field": "days",
          "type": "temporal"
        }
      },
      "mark": {
        "color": "gray",
        "type": "rule"
      },
      "transform": [
        {
          "filter": {
            "selection": "selector041"
          }
        }
      ]
    },
    {
      "data": {
        "name": "data-5f0f5ff84876a23e79b92d513f6417a5"
      },
      "encoding": {
        "text": {
          "field": "days",
          "timeUnit": "monthdate",
          "type": "temporal"
        },
        "x": {
          "field": "days",
          "type": "temporal"
        },
        "y": {
          "axis": null,
          "field": "y",
          "type": "quantitative"
        }
      },
      "mark": {
        "align": "left",
        "color": "gray",
        "dx": 5,
        "dy": -10,
        "fontWeight": 600,
        "type": "text"
      },
      "transform": [
        {
          "filter": {
            "selection": "selector041"
          }
        }
      ]
    },
    {
      "data": {
        "name": "data-9f2c8635c2b2a676ea596b4b4cb25013"
      },
      "encoding": {
        "color": {
          "field": "activity",
          "scale": {
            "domain": [
              "Treatment: Compost",
              "Treatment: Spray Round"
            ],
            "range": [
              "rgba(105,105,191,0.8)",
              "rgba(102,187,106,0.8)",
              "rgba(255,167,38,0.8)",
              "rgba(139,61,119,0.8)",
              "rgba(56,147,255,0.8)",
              "rgba(144,88,211,0.8)",
              "rgba(86,139,75,0.8)",
              "rgba(178,122,21,0.8)",
              "rgba(3,84,178,0.8)",
              "rgba(216,138,196,0.8)",
              "rgba(30,7,58,0.8)",
              "rgba(172,159,132,0.8)",
              "rgba(211,160,88,0.8)",
              "rgba(227,26,28,0.8)",
              "rgba(251,154,153,0.8)",
              "rgba(166,206,227,0.8)",
              "rgba(255,127,0,0.8)"
            ]
          },
          "type": "nominal"
        },
        "tooltip": [
          {
            "field": "sector",
            "title": "Block",
            "type": "nominal"
          },
          {
            "field": "day",
            "title": "Date",
            "type": "temporal"
          },
          {
            "field": "activity",
            "title": "Activity",
            "type": "nominal"
          }
        ],
        "x": {
          "axis": {
            "grid": false,
            "title": ""
          },
          "field": "day_sameyear",
          "scale": {
            "padding": 10
          },
          "type": "temporal"
        },
        "y": {
          "axis": {
            "grid": true
          },
          "field": "season",
          "sort": {
            "field": "day",
            "order": "descending"
          },
          "type": "nominal"
        }
      },
      "mark": {
        "opacity": 1,
        "size": 100,
        "type": "circle"
      },
      "selection": {
        "selector040": {
          "type": "single"
        }
      }
    }
  ],
  "title": "",
  "width": "container"
}                

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 P2 Important Issues that should be fixed soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants