Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate es2015 output #7595

Merged
merged 1 commit into from Aug 6, 2021
Merged

fix: generate es2015 output #7595

merged 1 commit into from Aug 6, 2021

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Jul 12, 2021

Fixes #7437

Undoes #7266

@domoritz domoritz requested a review from a team July 15, 2021 03:02
@hydrosquall
Copy link
Member

Thanks for updating this! I tried downgrading to 5.0.0 in a local build, and confirmed that it imports without error in create-react-app's default typescript template.

@domoritz
Copy link
Member Author

CRA is still on Webpack 4 but hopefully will update to Webpack 5 soon.

@hydrosquall
Copy link
Member

hydrosquall commented Jul 28, 2021

Would it be possible to release this as a 5.1.1? I have a project where we can't downgrade to 5.0.0 because it has strictNullChecks enabled, so we would be aiming to have the other feature from 5.1.0 #7352 in the bundle too.

@domoritz
Copy link
Member Author

@kanitw Can you merge and make a patch release?

@hydrosquall
Copy link
Member

hydrosquall commented Jul 29, 2021

I tried deploying a copy of this branch to check the output, but there are non es2015 symbols still making their way into the built bundle, specifically nullish coalescing (??). It's possible that I'm somehow running the build step differently (e.g. with a different node version) This may create issues for create-react-app / webpack4 users.

https://www.runpkg.com/?@hydrosquall/vega-lite@5.1.0-canary-0/build/vega-lite.js

image

Image 2021-07-29 at 12 29 41 AM

I'm not very familiar with rollup / how it transforms the original output of tsc, so I just wanted to flag it as a possible additional detail to investigate before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 5.1.0 breaks react-vega
3 participants